Review main Merged

61660[DOCS] Remove unused Fieldset property in documentation of EXT:form

TYPO3com CR +2 V +2 Easy +0 −3 updated 09/20/19, 10:32

Commit message

The "containerClassAttribute" property is not respected by elements of
type "Fieldset" as the partial "Field/Field" takes care of its
rendering. Therefore, it has been removed from the official documentation
to avoid confusions.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Björn Jacob +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1220

  1. TYPO3com uploaded patch set 1 09/10/19, 13:43

  2. Elias Häußler updated the commit message in patch set 2 09/10/19, 13:45

  3. TYPO3com voted on patch set 1 V +1 09/10/19, 14:00 Completed build in 13m 34s on Tue, 10 Sep, 02:00 PM Test Summary: 47458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36259

  4. TYPO3com voted on patch set 2 V +1 09/10/19, 14:04 Completed build in 17m 23s on Tue, 10 Sep, 02:04 PM Test Summary: 47458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36260

  5. Susi Moog updated the commit message in patch set 3 09/11/19, 12:40

  6. TYPO3com voted on patch set 3 V -1 09/11/19, 13:29 Completed build in 32m 45s on Wed, 11 Sep, 01:29 PM Test Summary: 1 of 47874 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36311

  7. Elias Häußler updated the commit message in patch set 4 09/11/19, 13:32

  8. TYPO3com voted on patch set 4 V +1 09/11/19, 13:48 Completed build in 12m 20s on Wed, 11 Sep, 01:48 PM Test Summary: 47515 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36317

  9. Björn Jacob updated the commit message in patch set 5 09/12/19, 08:30

  10. Björn Jacob commented on patch set 5 V +1 CR +1 09/12/19, 08:30

    Changed the patch back to [TASK] since this is the official tag. IMHO, there is no [DOCS] :)
  11. Elias Häußler commented on patch set 5 09/12/19, 08:39

    > Patch Set 5: Verified+1 Code-Review+1 > > Changed the patch back to [TASK] since this is the official tag. IMHO, there is no [DOCS] :) According to the Commit message rules, I thought this would be the best example for the usage of [DOCS] as it is stated as > [DOCS] > This tag is used for changes regarding the documentation. (https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/Appendix/CommitMessage.html#summary-line-first-line)
  12. TYPO3com voted on patch set 5 V +1 09/12/19, 08:40 Completed build in 09m 54s on Thu, 12 Sep, 08:40 AM Test Summary: 47536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36345

  13. Björn Jacob commented on patch set 5 09/12/19, 08:43

    > Patch Set 5: > > > Patch Set 5: Verified+1 Code-Review+1 > > > > Changed the patch back to [TASK] since this is the official tag. IMHO, there is no [DOCS] :) > > According to the Commit message rules, I thought this would be the best example for the usage of [DOCS] as it is stated as > > > [DOCS] > > This tag is used for changes regarding the documentation. > > (https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/Appendix/CommitMessage.html#summary-line-first-line) Never have seen this one for the commits. It is up to you. I am fine with both "tags". Feel free to change it back ;)
  14. Elias Häußler updated the commit message in patch set 6 09/19/19, 08:51

  15. TYPO3com voted on patch set 6 V -1 09/19/19, 09:00 Completed build in 09m 33s on Thu, 19 Sep, 09:00 AM Test Summary: 47074 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36571

  16. TYPO3com voted on patch set 6 V +1 09/19/19, 09:22 Completed build in 40m 46s on Thu, 19 Sep, 09:22 AM Test Summary: 47555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36571

  17. Björn Jacob voted on patch set 6 V +1 CR +1 09/19/19, 12:03

  18. Frank Nägler voted on patch set 6 V +2 CR +2 09/20/19, 10:19

  19. Frank Nägler merged patch set 7 09/20/19, 10:19

  20. Frank Nägler commented on patch set 7 09/20/19, 10:32

    follow up to remove the unused include file: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61769 For the backports of this patch, I removed the file, so the follow up is master only.