61663[BUGFIX] Correctly retrieve workspace versions
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Daniel Gorges +1
- Achim Fritz +1
-
Verified V +2 Done
- Benni Mack +2
- Daniel Gorges +1
- TYPO3com +1 CI
Issues 1
Files 12
- typo3/sysext/backend/Classes/Clipboard/Clipboard.php+6 −7
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+6 −14
- typo3/sysext/backend/Tests/Functional/Clipboard/ClipboardTest.phpnew+158 −0
- typo3/sysext/backend/Tests/Functional/Controller/PageLayoutControllerTest.phpnew+141 −0
- typo3/sysext/backend/Tests/Functional/Fixtures/CommonScenario.yamlnew+149 −0
- typo3/sysext/core/Classes/DataHandling/SlugHelper.php+3 −14
- typo3/sysext/core/Tests/Functional/SiteHandling/SiteBasedTestTrait.php+15 −0
- typo3/sysext/core/composer.json+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/AbstractTestCase.php+0 −15
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php+3 −14
- composer.json+1 −1
- composer.lock+14 −14
Review log 1220
-
Oliver Hader uploaded patch set 1 09/10/19, 21:55
-
TYPO3com voted on patch set 1 V -1 09/10/19, 21:55 Completed build in 14s on Tue, 10 Sep, 09:55 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36267
-
Oliver Hader commented on patch set 1 09/10/19, 21:58
composer.lock changes should be checked again carefully (or recreated) -
Oliver Hader uploaded patch set 2 09/10/19, 22:02
-
TYPO3com voted on patch set 2 V -1 09/10/19, 22:12 Completed build in 09m 45s on Tue, 10 Sep, 10:12 PM Test Summary: 47246 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36268
-
TYPO3com voted on patch set 2 V +1 09/10/19, 22:13 Completed build in 21m 14s on Tue, 10 Sep, 10:13 PM Test Summary: 47494 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36268
-
Oliver Hader uploaded patch set 3 09/10/19, 22:21
-
Oliver Hader uploaded patch set 4 09/10/19, 22:23
-
TYPO3com voted on patch set 3 V -1 09/10/19, 22:31 Completed build in 09m 50s on Tue, 10 Sep, 10:31 PM Test Summary: 47267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36269
-
TYPO3com voted on patch set 4 V -1 09/10/19, 22:35 Completed build in 11m 48s on Tue, 10 Sep, 10:35 PM Test Summary: 1 of 47853 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36270
-
Oliver Hader uploaded patch set 5 09/11/19, 07:06
-
TYPO3com voted on patch set 5 V +1 09/11/19, 07:16 Completed build in 09m 59s on Wed, 11 Sep, 07:16 AM Test Summary: 47494 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36283
-
TYPO3com voted on patch set 4 V +1 09/11/19, 07:24 Completed build in 9h 12m 42s on Wed, 11 Sep, 07:24 AM Test Summary: 47494 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36270
-
TYPO3com voted on patch set 3 V +1 09/11/19, 07:24 Completed build in 9h 13m 13s on Wed, 11 Sep, 07:24 AM Test Summary: 47494 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36269
-
Oliver Hader commented on patch set 5 09/11/19, 08:07
This change is ready for review. -
Benni Mack voted on patch set 5 V +1 CR +1 09/11/19, 08:31
-
Daniel Gorges voted on patch set 5 V +1 CR +1 09/11/19, 09:50
-
Benni Mack voted on patch set 5 V +2 CR +2 09/11/19, 10:20
-
Achim Fritz voted on patch set 5 CR +1 09/11/19, 10:24
-
Benni Mack merged patch set 6 09/11/19, 10:28