Review main Merged

61663[BUGFIX] Correctly retrieve workspace versions

Oliver Hader CR +2 V +2 Hard +497 −80 updated 09/11/19, 10:28

Commit message

* Clipboard now correctly resolves record localizations of a workspace
* PageLayoutController new correctly determines sub-pages that are new
  in a particular workspace
* SlugHelper & TypoScriptTemplateModuleController can be simplified
  by using WorkspaceRestriction directly
* common function test scenario tree (based on YAML) is introduced
  for ext:backend in order to be used as structure for other tests
* required testing framework changes support version and language
  variants and combination much better now

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Gorges +1
    • Achim Fritz +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Gorges +1
    • TYPO3com +1 CI

Issues 1

Files 12

Review log 1220

  1. Oliver Hader uploaded patch set 1 09/10/19, 21:55

  2. TYPO3com voted on patch set 1 V -1 09/10/19, 21:55 Completed build in 14s on Tue, 10 Sep, 09:55 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36267

  3. Oliver Hader commented on patch set 1 09/10/19, 21:58

    composer.lock changes should be checked again carefully (or recreated)
  4. Oliver Hader uploaded patch set 2 09/10/19, 22:02

  5. TYPO3com voted on patch set 2 V -1 09/10/19, 22:12 Completed build in 09m 45s on Tue, 10 Sep, 10:12 PM Test Summary: 47246 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36268

  6. TYPO3com voted on patch set 2 V +1 09/10/19, 22:13 Completed build in 21m 14s on Tue, 10 Sep, 10:13 PM Test Summary: 47494 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36268

  7. Oliver Hader uploaded patch set 3 09/10/19, 22:21

  8. Oliver Hader uploaded patch set 4 09/10/19, 22:23

  9. TYPO3com voted on patch set 3 V -1 09/10/19, 22:31 Completed build in 09m 50s on Tue, 10 Sep, 10:31 PM Test Summary: 47267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36269

  10. TYPO3com voted on patch set 4 V -1 09/10/19, 22:35 Completed build in 11m 48s on Tue, 10 Sep, 10:35 PM Test Summary: 1 of 47853 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36270

  11. Oliver Hader uploaded patch set 5 09/11/19, 07:06

  12. TYPO3com voted on patch set 5 V +1 09/11/19, 07:16 Completed build in 09m 59s on Wed, 11 Sep, 07:16 AM Test Summary: 47494 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36283

  13. TYPO3com voted on patch set 4 V +1 09/11/19, 07:24 Completed build in 9h 12m 42s on Wed, 11 Sep, 07:24 AM Test Summary: 47494 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36270

  14. TYPO3com voted on patch set 3 V +1 09/11/19, 07:24 Completed build in 9h 13m 13s on Wed, 11 Sep, 07:24 AM Test Summary: 47494 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36269

  15. Oliver Hader commented on patch set 5 09/11/19, 08:07

    This change is ready for review.
  16. Benni Mack voted on patch set 5 V +1 CR +1 09/11/19, 08:31

  17. Daniel Gorges voted on patch set 5 V +1 CR +1 09/11/19, 09:50

  18. Benni Mack voted on patch set 5 V +2 CR +2 09/11/19, 10:20

  19. Achim Fritz voted on patch set 5 CR +1 09/11/19, 10:24

  20. Benni Mack merged patch set 6 09/11/19, 10:28