Review main Merged

61666[BUGFIX] Fix assertion ordering in test cases

Oliver Hader CR +2 V +2 Easy +15 −2 updated 09/11/19, 11:57

Commit message

* use assertEqualsCanonicalizing instead of assertSame
  on array values to ignore ordering
* apply sorting order for localizations retrieved in
  Clipboard (drive-by fix)
* properly tearDown left-over instances of previous
  test execution

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 34

  1. Oliver Hader uploaded patch set 1 09/11/19, 11:44

  2. TYPO3com voted on patch set 1 V +1 09/11/19, 11:56 Completed build in 12m 34s on Wed, 11 Sep, 11:56 AM Test Summary: 47494 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36298

  3. Benni Mack voted on patch set 1 V +2 CR +2 09/11/19, 11:57

  4. Benni Mack merged patch set 2 09/11/19, 11:57