61669[TASK] Remove further evaluations of pid=-1
Commit message
Review
-
Code review CR +2 Done
- Frank Nägler +2
- Georg Ringer +1
- Achim Fritz +1
-
Verified V +2 Done
- Frank Nägler +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 4
Review log 1522
-
Benni Mack uploaded patch set 1 09/12/19, 05:40
-
TYPO3com voted on patch set 1 V -1 09/12/19, 05:55 Completed build in 14m 31s on Thu, 12 Sep, 05:55 AM Test Summary: 1 of 47874 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36332
-
Andreas Kienast commented on patch set 1 09/12/19, 06:08
-
Benni Mack uploaded patch set 2 09/12/19, 06:54
-
Benni Mack uploaded patch set 3 09/12/19, 06:58
-
TYPO3com voted on patch set 2 V +1 09/12/19, 07:08 Completed build in 11m 33s on Thu, 12 Sep, 07:08 AM Test Summary: 47536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36337
-
TYPO3com voted on patch set 3 V -1 09/12/19, 07:13 Completed build in 11m 52s on Thu, 12 Sep, 07:13 AM Test Summary: 47286 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36338
-
TYPO3com commented on patch set 3 09/12/19, 09:12 Completed build in 20m 41s on Thu, 12 Sep, 09:12 AM Test Summary: 47289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36338
-
Benni Mack uploaded patch set 4 09/12/19, 10:33
-
TYPO3com voted on patch set 4 V -1 09/12/19, 10:41 Completed build in 08m 27s on Thu, 12 Sep, 10:41 AM Test Summary: 47287 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36350
-
TYPO3com voted on patch set 4 V +1 09/12/19, 10:56 Completed build in 32m 04s on Thu, 12 Sep, 10:56 AM Test Summary: 47536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36350
-
Benni Mack updated the commit message in patch set 5 09/12/19, 12:06
-
TYPO3com voted on patch set 5 V +1 09/12/19, 12:18 Completed build in 11m 24s on Thu, 12 Sep, 12:18 PM Test Summary: 47536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36361
-
Achim Fritz voted on patch set 5 CR +1 09/13/19, 05:39
-
Georg Ringer commented on patch set 5 09/13/19, 07:05
is the todo for later or must be fixed within this issue? -
Benni Mack commented on patch set 5 09/13/19, 07:08
> Patch Set 5: > > is the todo for later or must be fixed within this issue? The ToDo is a separate spot, which I found during checking the code. So, yes. a different issue we need to address - basically getting rid of BackendUtility::getRecordLocalization() as it has nasty side effects. -
Georg Ringer voted on patch set 5 V +1 CR +1 09/13/19, 12:28
-
Frank Nägler commented on patch set 5 CR -1 09/13/19, 13:09
DataHandler.php:5170for different values, this expression evaluates: NULL => FALSE "" => FALSE -1 => TRUE 0 => FALSE 1 => TRUE Maybe I am wrong, but this looks broken. -
Frank Nägler commented on patch set 5 CR +1 09/13/19, 13:17
DataHandler.php:5170Reply Unresolvedtalked to Benni this is ok. -1 is a not valid value. -
Benni Mack commented on patch set 5 09/13/19, 13:18
yup. if t3ver_oid is <0 then we have a serious issue ;) t3ver_oid is auto-created and managed by TYPO3. If people do bad things with these fields in extension, bad things will happen to them. But that was the case before as well -
Frank Nägler voted on patch set 5 V +2 CR +2 09/13/19, 13:29
-
Frank Nägler merged patch set 6 09/13/19, 13:29
DataHandler.php:6542Unresolved