61670[BUGFIX] Check for plain integer values in QueryGenerator::cleanInputVal()
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Frank Nägler +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Frank Nägler +1
- TYPO3com +1 CI
Issues 2
Files 1
Review log 1722
-
Andreas Kienast uploaded patch set 1 09/12/19, 06:30
-
Andreas Kienast wrote 09/12/19, 06:31
Unset private -
TYPO3com voted on patch set 1 V +1 09/12/19, 06:40 Completed build in 10m 03s on Thu, 12 Sep, 06:40 AM Test Summary: 47514 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36334
-
Susi Moog commented on patch set 1 09/12/19, 07:40
QueryGenerator.php:1371Unresolvedthis is quite a change of behaviour and I think will break use cases: strtotime accepts strings like "next Tuesday" or a date format - which will then at a later point be used / converted to a timestamp as far as I understood (see the patch that broke the nightlies). I fear that something breakis with this change (as the suffix in that case goes missing) - not sure on when and how that suffix is used, but can you check that's not a problem please? -
Andreas Kienast uploaded patch set 2 09/12/19, 08:06
-
Andreas Kienast uploaded patch set 3 09/12/19, 08:07
-
TYPO3com voted on patch set 2 V -1 09/12/19, 08:16 Completed build in 09m 38s on Thu, 12 Sep, 08:16 AM Test Summary: 1 of 47814 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36343
-
TYPO3com voted on patch set 3 V +1 09/12/19, 08:19 Completed build in 11m 43s on Thu, 12 Sep, 08:19 AM Test Summary: 47536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36344
-
Sascha Egerer commented on patch set 3 CR -1 09/12/19, 10:14
QueryGenerator.php:1371This match is to weak. The `else` below will now only be used if the value is not an array. So everything that does not match one of the cases before will now be casted to int if not a time, right? -
Andreas Kienast commented on patch set 3 09/12/19, 10:20
QueryGenerator.php:1371ReplyAck -
Andreas Kienast uploaded patch set 4 09/12/19, 10:21
-
Sascha Egerer commented on patch set 4 09/12/19, 10:28
QueryGenerator.php:1376Hm I wonder why is everything casted to float that does not match one of the other conditions... Did you understand the code and if so could you maybe add some comments? -
TYPO3com voted on patch set 4 V +1 09/12/19, 10:32 Completed build in 10m 59s on Thu, 12 Sep, 10:32 AM Test Summary: 47536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36348
-
Andreas Kienast commented on patch set 4 09/12/19, 10:45
QueryGenerator.php:1376Reply UnresolvedNo, I didn't go back that far in history. I just found a commit of 2016 that interchanges doubleval with float casting. Looks like the code was never touched in a bigger scope. -
Oliver Klee commented on patch set 4 09/12/19, 10:46
Can we please cover at least the new behavior with unit tests? -
Andreas Kienast commented on patch set 4 09/12/19, 10:48
> Patch Set 4: > > Can we please cover at least the new behavior with unit tests? There is already a functional test being broken on mssql. -
Oliver Klee commented on patch set 4 09/12/19, 10:52
> There is already a functional test being broken on mssql. Still, this method is an excellent candidate for unit tests that allow testing the root of the problem, not only for the fallout. -
Andreas Kienast uploaded patch set 5 09/13/19, 07:33
-
Frank Nägler voted on patch set 5 V +1 CR +1 09/13/19, 07:41
-
TYPO3com voted on patch set 5 V +1 09/13/19, 07:44 Completed build in 10m 59s on Fri, 13 Sep, 07:44 AM Test Summary: 47536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36394
-
Anja Leichsenring voted on patch set 5 V +2 CR +2 09/13/19, 07:45
-
Anja Leichsenring merged patch set 6 09/13/19, 07:45