Review main Merged

61671[BUGFIX] Keep workspace ID when discarding versioned records

Benni Mack CR +2 V +2 Hard +310 −264 updated 09/13/19, 11:45

Commit message

When a record was modified in a workspace, and then discarded, TYPO3 previously
set the t3ver_wsid to "0", which basically meant "we release it to live workspace
as a offline version with pid=-1".

However, this turns out to be ugly, as this information is then floating in live workspace,
without any information where this record was from.

Instead, "discarding versioned records" now keeps the t3ver_wsid=X, and just marks
the versioned record as "deleted" - or removes it completely if the database table
does not support to mark records as deleted.

As a result, there will be no records in live workspace anymore with "pid=-1" in the future
anymore. To remove any "old" discarded records, an upgrade wizard will follow
in a followup patch.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Daniel Gorges +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Daniel Gorges +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 50

Show 30 more files

Review log 2236

Show 611 earlier messages
  1. Benni Mack uploaded patch set 1 09/12/19, 06:50

  2. TYPO3com voted on patch set 1 V -1 09/12/19, 07:01 Completed build in 11m 03s on Thu, 12 Sep, 07:01 AM Test Summary: 72 of 47874 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36335

  3. Oliver Hader uploaded patch set 2 09/12/19, 09:30

  4. TYPO3com voted on patch set 2 V -1 09/12/19, 09:40 Completed build in 09m 54s on Thu, 12 Sep, 09:40 AM Test Summary: 48 of 47895 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36346

  5. Oliver Hader uploaded patch set 3 09/12/19, 09:45

  6. TYPO3com voted on patch set 3 V -1 09/12/19, 09:54 Completed build in 09m 13s on Thu, 12 Sep, 09:54 AM Test Summary: 48 of 47895 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36347

  7. Oliver Hader uploaded patch set 4 09/12/19, 11:32

  8. TYPO3com voted on patch set 4 V -1 09/12/19, 11:46 Completed build in 13m 46s on Thu, 12 Sep, 11:46 AM Test Summary: 25 of 47895 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36357

  9. Oliver Hader uploaded patch set 5 09/12/19, 14:49

  10. Oliver Hader commented on patch set 5 09/12/19, 14:58

    modifyParentNHotelChildNDiscardAll.csv:12 Unresolved

    hm... move-placeholder

    modifyParentNHotelChildNDiscardModifiedParent.csv:10 Unresolved

    probably a regression

    modifyNDiscardNModifyParentWHotelChild.csv:3 Unresolved

    +1 drive-by bug fix

    modifyNDiscardNModifyParentWHotelChild.csv:13 Unresolved

    has to be checked

    changePageSorting.csv:3 Unresolved

    slugs missing since not part of CSV header
  11. TYPO3com voted on patch set 5 V -1 09/12/19, 15:08 Completed build in 11m 49s on Thu, 12 Sep, 03:08 PM Test Summary: 40 of 47895 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36387

  1. Oliver Hader uploaded patch set 6 09/12/19, 15:28

  2. TYPO3com voted on patch set 6 V -1 09/12/19, 15:38 Completed build in 09m 38s on Thu, 12 Sep, 03:38 PM Test Summary: 40 of 37888 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36389

  3. Oliver Hader uploaded patch set 7 09/13/19, 07:23

  4. TYPO3com voted on patch set 7 V -1 09/13/19, 07:32 Completed build in 08m 19s on Fri, 13 Sep, 07:32 AM Test Summary: 32 of 47645 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36392

  5. Oliver Hader uploaded patch set 8 09/13/19, 08:38

  6. Oliver Hader commented on patch set 8 CR -1 09/13/19, 08:46

    modifyNDiscardNModifyParentWHotelChild.csv:6 Unresolved

    Bug in tests...

    changePageSorting.csv:2 Unresolved

    slug missing
  7. TYPO3com voted on patch set 8 V -1 09/13/19, 09:16 Completed build in 29m 22s on Fri, 13 Sep, 09:16 AM Test Summary: 2 of 47895 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36396

  8. Oliver Hader uploaded patch set 9 09/13/19, 09:42

  9. Oliver Hader uploaded patch set 10 09/13/19, 09:46

  10. TYPO3com voted on patch set 9 V -1 09/13/19, 10:08 Completed build in 13m 29s on Fri, 13 Sep, 10:08 AM Test Summary: 6 of 47895 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36400

  11. TYPO3com voted on patch set 10 V -1 09/13/19, 10:15 Completed build in 20m 40s on Fri, 13 Sep, 10:15 AM Test Summary: 6 of 47895 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36401

  12. Benni Mack updated the commit message in patch set 11 09/13/19, 10:25

  13. Oliver Hader uploaded patch set 12 09/13/19, 10:26

  14. TYPO3com voted on patch set 11 V -1 09/13/19, 10:39 Completed build in 13m 05s on Fri, 13 Sep, 10:39 AM Test Summary: 19 of 47580 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36407

  15. TYPO3com voted on patch set 12 V +1 09/13/19, 10:43 Completed build in 16m 38s on Fri, 13 Sep, 10:43 AM Test Summary: 47536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36408

  16. Benni Mack updated the commit message in patch set 13 09/13/19, 10:49

  17. Benni Mack voted on patch set 13 V +1 CR +1 09/13/19, 10:59

  18. Oliver Hader voted on patch set 13 V +1 CR +1 09/13/19, 10:59

  19. Benni Mack uploaded patch set 14 09/13/19, 11:06

  20. Benni Mack voted on patch set 14 V +1 CR +1 09/13/19, 11:07

  21. TYPO3com voted on patch set 13 V +1 09/13/19, 11:11 Completed build in 12m 43s on Fri, 13 Sep, 11:11 AM Test Summary: 47536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36415

  22. Daniel Gorges voted on patch set 14 V +1 CR +1 09/13/19, 11:20

  23. TYPO3com voted on patch set 14 V +1 09/13/19, 11:34 Completed build in 18m 36s on Fri, 13 Sep, 11:34 AM Test Summary: 47536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36417

  24. Oliver Hader voted on patch set 14 V +2 CR +2 09/13/19, 11:45

  25. Oliver Hader merged patch set 15 09/13/19, 11:45