61671[BUGFIX] Keep workspace ID when discarding versioned records
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Daniel Gorges +1
- Benni Mack +1
-
Verified V +2 Done
- Oliver Hader +2
- Daniel Gorges +1
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 50
- typo3/sysext/core/Tests/Functional/DataHandling/AbstractDataHandlerActionTestCase.php+30 −11
- typo3/sysext/core/composer.json+1 −1
- typo3/sysext/workspaces/Classes/Dependency/ElementEntity.php+7 −2
- typo3/sysext/workspaces/Classes/Dependency/ElementEntityProcessor.php+13 −1
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php+57 −47
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/createNCopyParentNHotelNOfferChildrenNDiscardCopiedParent.csv+6 −6
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/createNLocParentNHotelNOfferChildrenNDiscardCreatedParent.csv+12 −12
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/createNLocParentNHotelNOfferChildrenNDiscardLocParent.csv+6 −6
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/modifyNDiscardNModifyParentWHotelChild.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/modifyParentNHotelChildNDiscardAll.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/modifyParentNHotelChildNDiscardModifiedParent.csv+1 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Publish/DataSet/createNCopyParentNHotelNOfferChildrenNDiscardCopiedParent.csv+6 −6
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Publish/DataSet/createNLocParentNHotelNOfferChildrenNDiscardCreatedParent.csv+12 −12
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Publish/DataSet/createNLocParentNHotelNOfferChildrenNDiscardLocParent.csv+6 −6
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Publish/DataSet/modifyNDiscardNModifyParentWHotelChild.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Publish/DataSet/modifyParentNHotelChildNDiscardAll.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Publish/DataSet/modifyParentNHotelChildNDiscardModifiedParent.csv+1 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/PublishAll/DataSet/createNCopyParentNHotelNOfferChildrenNDiscardCopiedParent.csv+6 −6
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/PublishAll/DataSet/createNLocParentNHotelNOfferChildrenNDiscardCreatedParent.csv+12 −12
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/PublishAll/DataSet/createNLocParentNHotelNOfferChildrenNDiscardLocParent.csv+6 −6
Show 30 more files
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/PublishAll/DataSet/modifyNDiscardNModifyParentWHotelChild.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/PublishAll/DataSet/modifyParentNHotelChildNDiscardAll.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/PublishAll/DataSet/modifyParentNHotelChildNDiscardModifiedParent.csv+1 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/createNCopyParentNHotelNOfferChildrenNDiscardCopiedParent.csv+6 −6
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/createNLocParentNHotelNOfferChildrenNDiscardCreatedParent.csv+12 −12
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/createNLocParentNHotelNOfferChildrenNDiscardLocParent.csv+6 −6
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/modifyNDiscardNModifyParentWHotelChild.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/modifyParentNHotelChildNDiscardAll.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/modifyParentNHotelChildNDiscardModifiedParent.csv+1 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Publish/DataSet/createNCopyParentNHotelNOfferChildrenNDiscardCopiedParent.csv+6 −6
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Publish/DataSet/createNLocParentNHotelNOfferChildrenNDiscardCreatedParent.csv+12 −12
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Publish/DataSet/createNLocParentNHotelNOfferChildrenNDiscardLocParent.csv+6 −6
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Publish/DataSet/modifyNDiscardNModifyParentWHotelChild.csv1+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Publish/DataSet/modifyParentNHotelChildNDiscardAll.csv1+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Publish/DataSet/modifyParentNHotelChildNDiscardModifiedParent.csv1+1 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/PublishAll/DataSet/createNCopyParentNHotelNOfferChildrenNDiscardCopiedParent.csv+6 −6
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/PublishAll/DataSet/createNLocParentNHotelNOfferChildrenNDiscardCreatedParent.csv+12 −12
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/PublishAll/DataSet/createNLocParentNHotelNOfferChildrenNDiscardLocParent.csv+6 −6
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/PublishAll/DataSet/modifyNDiscardNModifyParentWHotelChild.csv2+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/PublishAll/DataSet/modifyParentNHotelChildNDiscardAll.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/PublishAll/DataSet/modifyParentNHotelChildNDiscardModifiedParent.csv+1 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/createContentNDiscardCreatedContent.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/createNCopyContentNDiscardCopiedContent.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/changePageSorting.csv2+1 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/createContentNDiscardCreatedContent.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/createNCopyContentNDiscardCopiedContent.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/DataSet/createContentNDiscardCreatedContent.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/DataSet/createNCopyContentNDiscardCopiedContent.csv+2 −2
- composer.json+1 −1
- composer.lock+14 −14
Review log 2236
Show 611 earlier messages
-
Benni Mack uploaded patch set 1 09/12/19, 06:50
-
TYPO3com voted on patch set 1 V -1 09/12/19, 07:01 Completed build in 11m 03s on Thu, 12 Sep, 07:01 AM Test Summary: 72 of 47874 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36335
-
Oliver Hader uploaded patch set 2 09/12/19, 09:30
-
TYPO3com voted on patch set 2 V -1 09/12/19, 09:40 Completed build in 09m 54s on Thu, 12 Sep, 09:40 AM Test Summary: 48 of 47895 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36346
-
Oliver Hader uploaded patch set 3 09/12/19, 09:45
-
TYPO3com voted on patch set 3 V -1 09/12/19, 09:54 Completed build in 09m 13s on Thu, 12 Sep, 09:54 AM Test Summary: 48 of 47895 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36347
-
Oliver Hader uploaded patch set 4 09/12/19, 11:32
-
TYPO3com voted on patch set 4 V -1 09/12/19, 11:46 Completed build in 13m 46s on Thu, 12 Sep, 11:46 AM Test Summary: 25 of 47895 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36357
-
Oliver Hader uploaded patch set 5 09/12/19, 14:49
-
Oliver Hader commented on patch set 5 09/12/19, 14:58
modifyParentNHotelChildNDiscardModifiedParent.csv:10Unresolvedprobably a regressionmodifyNDiscardNModifyParentWHotelChild.csv:3Unresolved+1 drive-by bug fixmodifyNDiscardNModifyParentWHotelChild.csv:13Unresolvedhas to be checkedchangePageSorting.csv:3Unresolvedslugs missing since not part of CSV header -
TYPO3com voted on patch set 5 V -1 09/12/19, 15:08 Completed build in 11m 49s on Thu, 12 Sep, 03:08 PM Test Summary: 40 of 47895 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36387
-
Oliver Hader uploaded patch set 6 09/12/19, 15:28
-
TYPO3com voted on patch set 6 V -1 09/12/19, 15:38 Completed build in 09m 38s on Thu, 12 Sep, 03:38 PM Test Summary: 40 of 37888 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36389
-
Oliver Hader uploaded patch set 7 09/13/19, 07:23
-
TYPO3com voted on patch set 7 V -1 09/13/19, 07:32 Completed build in 08m 19s on Fri, 13 Sep, 07:32 AM Test Summary: 32 of 47645 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36392
-
Oliver Hader uploaded patch set 8 09/13/19, 08:38
-
Oliver Hader commented on patch set 8 CR -1 09/13/19, 08:46
modifyNDiscardNModifyParentWHotelChild.csv:6UnresolvedBug in tests...changePageSorting.csv:2Unresolvedslug missing -
TYPO3com voted on patch set 8 V -1 09/13/19, 09:16 Completed build in 29m 22s on Fri, 13 Sep, 09:16 AM Test Summary: 2 of 47895 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36396
-
Oliver Hader uploaded patch set 9 09/13/19, 09:42
-
Oliver Hader uploaded patch set 10 09/13/19, 09:46
-
TYPO3com voted on patch set 9 V -1 09/13/19, 10:08 Completed build in 13m 29s on Fri, 13 Sep, 10:08 AM Test Summary: 6 of 47895 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36400
-
TYPO3com voted on patch set 10 V -1 09/13/19, 10:15 Completed build in 20m 40s on Fri, 13 Sep, 10:15 AM Test Summary: 6 of 47895 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36401
-
Benni Mack updated the commit message in patch set 11 09/13/19, 10:25
-
Oliver Hader uploaded patch set 12 09/13/19, 10:26
-
TYPO3com voted on patch set 11 V -1 09/13/19, 10:39 Completed build in 13m 05s on Fri, 13 Sep, 10:39 AM Test Summary: 19 of 47580 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36407
-
TYPO3com voted on patch set 12 V +1 09/13/19, 10:43 Completed build in 16m 38s on Fri, 13 Sep, 10:43 AM Test Summary: 47536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36408
-
Benni Mack updated the commit message in patch set 13 09/13/19, 10:49
-
Benni Mack voted on patch set 13 V +1 CR +1 09/13/19, 10:59
-
Oliver Hader voted on patch set 13 V +1 CR +1 09/13/19, 10:59
-
Benni Mack uploaded patch set 14 09/13/19, 11:06
-
Benni Mack voted on patch set 14 V +1 CR +1 09/13/19, 11:07
-
TYPO3com voted on patch set 13 V +1 09/13/19, 11:11 Completed build in 12m 43s on Fri, 13 Sep, 11:11 AM Test Summary: 47536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36415
-
Daniel Gorges voted on patch set 14 V +1 CR +1 09/13/19, 11:20
-
TYPO3com voted on patch set 14 V +1 09/13/19, 11:34 Completed build in 18m 36s on Fri, 13 Sep, 11:34 AM Test Summary: 47536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36417
-
Oliver Hader voted on patch set 14 V +2 CR +2 09/13/19, 11:45
-
Oliver Hader merged patch set 15 09/13/19, 11:45
modifyParentNHotelChildNDiscardAll.csv:12Unresolved