Review 9.5 Merged

61673[BUGFIX] Strip tags in prepared label from suggest wizard

Georg Ringer CR +2 V +2 Easy +1 −1 updated 10/14/19, 20:25

Commit message

Labels of records provided by the suggest wizard should not contain
any HTML content as they are directly applied as <option> element
to the <select> element of the appropriate database field in backend
forms.

As the suggest wizard may generate such labels in case of stripped
record titles, this commit strips away all HTML tags in order to apply
the labels in a clean way to the appropriate element in the DOM.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Georg Ringer +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 46

  1. Georg Ringer commented on patch set 1 09/12/19, 18:27

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 09/12/19, 18:39 Completed build in 11m 56s on Thu, 12 Sep, 06:39 PM Test Summary: 50656 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1148

  3. TYPO3com voted on patch set 1 V +1 09/13/19, 07:06 Completed build in 12h 50m 13s on Fri, 13 Sep, 07:06 AM Test Summary: 50665 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1148

  4. Georg Ringer voted on patch set 1 V +2 CR +2 09/19/19, 08:09

  5. Georg Ringer merged patch set 2 09/19/19, 08:09

  6. Oliver Hader commented on patch set 2 CR +1 10/14/19, 20:25

    SuggestWizardDefaultReceiver.php:198 Unresolved

    Fine, it's something like `<span title="Original Title">Orig...</span>` and it is HTML-encoded