Review main Merged

61692[BUGFIX] Load language labels in RecordProvider

Andreas Kienast CR +2 V +2 Easy +11 −3 updated 09/25/19, 10:30

Commit message

The generic RecordProvider used for context menus now explicitly loads
the language labels for the modals.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Benjamin Franzke +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Benjamin Franzke +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1317

  1. Andreas Kienast uploaded patch set 1 09/12/19, 07:33

  2. Susi Moog voted on patch set 1 CR +1 09/12/19, 07:36

  3. TYPO3com voted on patch set 1 V +1 09/12/19, 07:43 Completed build in 09m 34s on Thu, 12 Sep, 07:43 AM Test Summary: 47536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36341

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 09/12/19, 09:53

  5. Benjamin Franzke commented on patch set 1 V +1 CR -1 09/14/19, 06:15

    Hm.. I think the real issue is that the context menu response doesn't include the labels. If we would enhance \TYPO3\CMS\Backend\ContextMenu\ItemProviders\RecordProvider::getDeleteAdditionalAttributes to include "data-button-ok-text" and "data-button-close-text" as addittional attribute in the contextmenu response, then ContextMenuActions.ts would pick up those values: + $closeText = $this->languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_common.xlf:cancel'); + $okText = $this->languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_common.xlf:delete'); $attributes += [ 'data-title' => htmlspecialchars($title), - 'data-message' => htmlspecialchars($confirmMessage) + 'data-message' => htmlspecialchars($confirmMessage), + 'data-button-close-text' => htmlspecialchars($closeText), + 'data-button-ok-text' => htmlspecialchars($okText), ]; That would have the advantage to fix this for other (possible) cases as well, and that the language labels do not need to be updated (thinking esp. of the 9.5 backport here), as we can use the existing labels, instead of creating new, redundant ones. Also, I think including the entire locallan_core.xlf file would make it hard to ever know: "well, can this be removed?"
  6. Andreas Kienast uploaded patch set 2 09/25/19, 09:51

  7. Frank Nägler voted on patch set 2 CR -1 09/25/19, 10:00

  8. Andreas Kienast uploaded patch set 3 09/25/19, 10:02

  9. Benjamin Franzke uploaded patch set 4 09/25/19, 10:02

  10. Andreas Kienast uploaded patch set 5 09/25/19, 10:02

  11. Benjamin Franzke voted on patch set 5 V +1 CR +1 09/25/19, 10:06

  12. TYPO3com voted on patch set 2 V -1 09/25/19, 10:07 Completed build in 12m 59s on Wed, 25 Sep, 10:07 AM Test Summary: 45 of 48079 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36795

  13. Frank Nägler voted on patch set 5 V +2 CR +2 09/25/19, 10:08

  14. Anja Leichsenring voted on patch set 5 V +1 CR +1 09/25/19, 10:11

  15. TYPO3com voted on patch set 4 V +1 09/25/19, 10:25 Completed build in 21m 39s on Wed, 25 Sep, 10:25 AM Test Summary: 47720 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36799

  16. TYPO3com voted on patch set 5 V +1 09/25/19, 10:29 Completed build in 25m 04s on Wed, 25 Sep, 10:29 AM Test Summary: 47720 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36800

  17. Frank Nägler merged patch set 6 09/25/19, 10:30