Review main Merged

61697[TASK] Move configuration viewHelper into sysext:core

Anja Leichsenring CR +2 V +2 Easy +10 −4 updated 09/12/19, 14:43

Commit message

The view helper will provide form fields for extension configuration
based on ext_template.txt files in install tool.

A similar functionality is to be implemented into the site module,
so the view helper is moved into sysext:core to be used from
both places.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1217

  1. Anja Leichsenring uploaded patch set 1 09/12/19, 14:07

  2. Anja Leichsenring uploaded patch set 2 09/12/19, 14:11

  3. Frank Nägler voted on patch set 2 CR +1 09/12/19, 14:12

  4. Anja Leichsenring uploaded patch set 3 09/12/19, 14:15

  5. Andreas Kienast voted on patch set 3 V +1 CR +1 09/12/19, 14:17

  6. Frank Nägler voted on patch set 3 V +1 CR +1 09/12/19, 14:18

  7. Frank Nägler voted on patch set 3 V +2 CR +2 09/12/19, 14:18

  8. TYPO3com voted on patch set 1 V -1 09/12/19, 14:19 Completed build in 12m 00s on Thu, 12 Sep, 02:19 PM Test Summary: 47287 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36376

  9. Andreas Kienast uploaded patch set 4 09/12/19, 14:22

  10. Andreas Kienast voted on patch set 4 V +1 CR +1 09/12/19, 14:22

  11. Anja Leichsenring uploaded patch set 5 09/12/19, 14:25

  12. TYPO3com voted on patch set 2 V -1 09/12/19, 14:27 Completed build in 13m 15s on Thu, 12 Sep, 02:27 PM Test Summary: 47536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36378

  13. Frank Nägler voted on patch set 5 V +2 CR +2 09/12/19, 14:28

  14. TYPO3com voted on patch set 3 V -1 09/12/19, 14:32 Completed build in 14m 05s on Thu, 12 Sep, 02:32 PM Test Summary: 1 of 47895 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36379

  15. TYPO3com voted on patch set 4 V +1 09/12/19, 14:36 Completed build in 13m 37s on Thu, 12 Sep, 02:36 PM Test Summary: 47536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36380

  16. Frank Nägler merged patch set 6 09/12/19, 14:37

  17. TYPO3com commented on patch set 5 09/12/19, 14:43 Completed build in 15m 57s on Thu, 12 Sep, 02:43 PM Test Summary: 47536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36381