Review main Merged

61698[BUGFIX] Strip tags in prepared label from suggest wizard

Elias Häußler CR +2 V +2 Easy +1 −1 updated 09/12/19, 18:27

Commit message

Labels of records provided by the suggest wizard should not contain
any HTML content as they are directly applied as <option> element
to the <select> element of the appropriate database field in backend
forms.

As the suggest wizard may generate such labels in case of stripped
record titles, this commit strips away all HTML tags in order to apply
the labels in a clean way to the appropriate element in the DOM.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Markus Klein +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Elias Häußler uploaded patch set 1 09/12/19, 14:26

  2. TYPO3com voted on patch set 1 V +1 09/12/19, 14:58 Completed build in 30m 22s on Thu, 12 Sep, 02:58 PM Test Summary: 47536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36384

  3. Markus Klein voted on patch set 1 V +1 CR +1 09/12/19, 15:44

  4. Georg Ringer voted on patch set 1 V +2 CR +2 09/12/19, 18:27

  5. Georg Ringer merged patch set 2 09/12/19, 18:27