Review main Merged

61700[DOCS] Use working examples in linkvalidator documentation

TYPO3com CR +2 V +2 Easy +37 −10 updated 10/28/19, 19:18

Commit message

Fields without softref are not being checked. Since pages:media does not
have softref set in its TCA it will never get checked. Field pages:url
has an unresolved issue since 6 years. So better don't mention it as an
example for configuration until it works.

The default configuration also contains the two fields.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
    • Sybille Peters +1
    • Daniel Siepmann +1
  • Verified V +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
    • Sybille Peters +1
    • Daniel Siepmann +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1621

  1. TYPO3com uploaded patch set 1 09/13/19, 03:16

  2. TYPO3com voted on patch set 1 V +1 09/13/19, 03:26 Completed build in 10m 06s on Fri, 13 Sep, 03:26 AM Test Summary: 47536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36391

  3. Lina Wolf commented on patch set 1 09/13/19, 13:43

    Hi Susi, habe ich hier alles richtig gemacht? muss ich hier jemanden aufmerksam machen und wenn ja wen? Grüße Lina
  4. Daniel Siepmann uploaded patch set 2 09/27/19, 14:03

  5. Daniel Siepmann voted on patch set 2 V +1 CR +1 09/27/19, 14:03

  6. TYPO3com voted on patch set 2 V +1 09/27/19, 14:23 Completed build in 13m 36s on Fri, 27 Sep, 02:23 PM Test Summary: 47716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36899

  7. Daniel Goerz updated the commit message in patch set 3 09/28/19, 09:05

  8. Daniel Goerz voted on patch set 3 V +1 CR +1 09/28/19, 09:06

  9. TYPO3com voted on patch set 3 V +1 09/28/19, 09:15 Completed build in 09m 31s on Sat, 28 Sep, 09:15 AM Test Summary: 47716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36911

  10. Björn Jacob commented on patch set 3 CR -1 09/28/19, 15:29

    I don't fully understand the example. Can you improve it? Here's my proposal.

    Index.rst:52

    "Would work" if what? Does this line mean the softref is already set? Or do I have to set it manually within my extension? Maybe it should read: "Works since :php:`$TCA['pages']['columns'][FIELD_NAME]['config']['softref'] == 'typolink'` is set by the TYPO3 core.

    Index.rst:55

    Is this better? "Dos not work since no softref is set for media."
  11. Sybille Peters commented on patch set 3 09/30/19, 16:26

    I agree the documentation should only include the fields that currently work. And it should be the same configuration as used in /Configuration/TsConfig/Page/pagetsconfig.tsconfig. So I would change that as well. Ideally the things that currently do now work should be fixed (there are already pending PR).
  12. Björn Jacob commented on patch set 3 09/30/19, 19:19

    > Patch Set 3: > > I agree the documentation should only include the fields that currently work. And it should be the same configuration as used in /Configuration/TsConfig/Page/pagetsconfig.tsconfig. So I would change that as well. > > Ideally the things that currently do now work should be fixed (there are already pending PR). I have not checked the code. I am just asking whether TYPO3 already ships the correct PHP settings or if I/ the integrator has to set up stuff. Know what I mean?
  13. Sybille Peters commented on patch set 3 10/01/19, 06:01

    > Patch Set 3: > > > Patch Set 3: > > > > I agree the documentation should only include the fields that currently work. And it should be the same configuration as used in /Configuration/TsConfig/Page/pagetsconfig.tsconfig. So I would change that as well. > > > > Ideally the things that currently do now work should be fixed (there are already pending PR). > > I have not checked the code. I am just asking whether TYPO3 already ships the correct PHP settings or if I/ the integrator has to set up stuff. Know what I mean? Linkvalidator should work and use the default settings if nothing is setup. You can override the default settings with TSconfig.
  14. Daniel Goerz voted on patch set 3 V 0 CR 0 10/06/19, 21:13

  15. Sybille Peters uploaded patch set 4 10/26/19, 11:58

  16. Sybille Peters commented on patch set 4 V +1 CR +1 10/26/19, 12:00

    Index.rst:52 Reply

    Done

    Index.rst:55 Reply

    Done
  17. TYPO3com voted on patch set 4 V +1 10/26/19, 12:13 Completed build in 12m 07s on Sat, 26 Oct, 12:13 PM Test Summary: 48067 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37789

  18. Daniel Siepmann voted on patch set 4 V +1 CR +1 10/26/19, 13:02

  19. Daniel Goerz voted on patch set 4 V +1 CR +1 10/27/19, 09:20

  20. Susi Moog voted on patch set 4 V +2 CR +2 10/28/19, 19:18

  21. Susi Moog merged patch set 5 10/28/19, 19:18