Review main Merged

61702[BUGFIX] Disallow phpdocumentor/reflection-docblock >= 4.3.2

Andreas Kienast CR +2 V +2 Easy +11 −9 updated 09/13/19, 10:59

Commit message

The package phpdocumentor/reflection-docblock introduces major regressions
starting with 4.3.2 that leads to getting nullable compound types (e.g.
`?string|int`) parsed completely wrong, which currently also breaks in
symfony/property-info.

Also, it became stricter about type annotations which currently collides
with Fluid.

For this reason, the package is marked as conflicting starting with
version 4.3.2.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1217

  1. Andreas Kienast uploaded patch set 1 09/13/19, 10:11

  2. Andreas Kienast updated the commit message in patch set 2 09/13/19, 10:12

  3. Mathias Brodala commented on patch set 2 09/13/19, 10:13

    composer.json:47

    Maybe use "^4.3 < 4.3.2" instead to avoid trouble with people which use e.g. "^4.3.1" or similar.
  4. Andreas Kienast commented on patch set 2 09/13/19, 10:16

    composer.json:47 Reply Unresolved

    Looks fine, will update the patch
  5. Andreas Kienast uploaded patch set 3 09/13/19, 10:18

  6. Andreas Kienast commented on patch set 3 CR -1 09/13/19, 10:20

    Adding the constraint as conflict should work as well...
  7. Andreas Kienast uploaded patch set 4 09/13/19, 10:25

  8. TYPO3com voted on patch set 4 V -1 09/13/19, 10:26 Completed build in 25s on Fri, 13 Sep, 10:26 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36406

  9. TYPO3com voted on patch set 1 V +1 09/13/19, 10:26 Completed build in 15m 12s on Fri, 13 Sep, 10:26 AM Test Summary: 47536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36403

  10. Andreas Kienast uploaded patch set 5 09/13/19, 10:27

  11. TYPO3com voted on patch set 3 V -1 09/13/19, 10:28 Completed build in 07m 07s on Fri, 13 Sep, 10:28 AM Test Summary: 55 of 41328 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36405

  12. Mathias Brodala voted on patch set 5 CR +1 09/13/19, 10:33

  13. TYPO3com voted on patch set 5 V -1 09/13/19, 10:35 Completed build in 20s on Fri, 13 Sep, 10:35 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36409

  14. Andreas Kienast uploaded patch set 6 09/13/19, 10:35

  15. TYPO3com voted on patch set 6 V +1 09/13/19, 10:59 Completed build in 15m 30s on Fri, 13 Sep, 10:59 AM Test Summary: 47536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36412

  16. Anja Leichsenring voted on patch set 6 V +2 CR +2 09/13/19, 10:59

  17. Anja Leichsenring merged patch set 7 09/13/19, 10:59