Review main Merged

61708[TASK] Add a function to safely traverse arrays in TS conditions

Markus Klein CR +2 V +2 Normal +79 −50 updated 01/12/20, 18:22

Commit message

Example:
[traverse(request.getQueryParams(), 'tx_news_pi/news') > 0]

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1619

  1. Markus Klein uploaded patch set 1 09/14/19, 21:41

  2. TYPO3com voted on patch set 1 V +1 09/14/19, 21:50 Completed build in 08m 50s on Sat, 14 Sep, 09:50 PM Test Summary: 47556 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36455

  3. Oliver Klee commented on patch set 1 09/14/19, 22:12

    Can we please have tests for this?
  4. Frank Nägler commented on patch set 1 09/16/19, 06:23

    Thanks for the patch, the new function looks valid, but this should be a FEATURE patch and needs a RST file. also as Olli mentioned some tests would be nice.
  5. Markus Klein commented on patch set 1 09/17/19, 09:18

    You may call it a feature, but it is a MUST HAVE for v9!
  6. Felix Nagel commented on patch set 1 V +1 CR +1 10/18/19, 12:50

    Tested in TYPO3 9.5.19. Works as expected.
  7. Wolfgang Klinger commented on patch set 1 10/18/19, 13:00

    Patch is good, I don't like the name though. 'traverse' does not clearly say what it does, why not simply call it something like 'parameter'? Would be much clearer as you can read it like a sentence: if parameter of request.getQueryParams() named 'tx_news_pi1/news' is greater than 0, then do something
  8. Wolfgang Klinger commented on patch set 1 10/18/19, 13:03

    > Patch Set 1: > > Patch is good, I don't like the name though. 'traverse' does not clearly say what it does, why not simply call it something like 'parameter'? Would be much clearer as you can read it like a sentence: if parameter of request.getQueryParams() named 'tx_news_pi1/news' is greater than 0, then do something … or value() or argument() or something like that to be more generic (as it's not always a GET parameter you want to tackle here)
  9. Markus Klein commented on patch set 1 10/18/19, 13:07

    > Patch Set 1: > > > Patch Set 1: > > > > Patch is good, I don't like the name though. 'traverse' does not clearly say what it does, why not simply call it something like 'parameter'? Would be much clearer as you can read it like a sentence: if parameter of request.getQueryParams() named 'tx_news_pi1/news' is greater than 0, then do something > > … or value() or argument() or something like that to be more generic (as it's not always a GET parameter you want to tackle here) I'm open for any better name. value() sounds tempting.
  10. Daniel Goerz commented on patch set 1 CR -1 10/20/19, 13:06

    Unresolved

    Patch is not done yet it seems :)
  11. Markus Klein uploaded patch set 2 01/12/20, 11:16

  12. TYPO3com voted on patch set 2 V +1 01/12/20, 11:46 Completed build in 45m 11s on Sun, 12 Jan, 11:46 AM Test Summary: 69191 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39804

  13. Susi Moog voted on patch set 2 CR +1 01/12/20, 17:00

  14. Susi Moog voted on patch set 2 V +1 01/12/20, 17:07

  15. Daniel Goerz uploaded patch set 3 01/12/20, 17:57

  16. Susi Moog voted on patch set 3 V +1 CR +1 01/12/20, 18:00

  17. TYPO3com voted on patch set 3 V +1 01/12/20, 18:06 Completed build in 08m 45s on Sun, 12 Jan, 06:06 PM Test Summary: 69206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39835

  18. Daniel Goerz voted on patch set 3 V +2 CR +2 01/12/20, 18:22

  19. Daniel Goerz merged patch set 4 01/12/20, 18:22