Review main Merged

61709[BUGFIX] Show Broken Links of Pages on the Page itself

Lina Wolf CR +2 V +2 Normal +93 −35 updated 10/23/19, 08:42

Commit message

Choose pages by uid and other records by pid to determine which ones
should be shown for a certain level in the Backend Info module.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Sybille Peters +1
    • Tymoteusz Motylewski +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Sybille Peters +1
    • Tymoteusz Motylewski +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 3149

Show 1324 earlier messages
  1. Lina Wolf uploaded patch set 1 09/15/19, 12:15

  2. TYPO3com voted on patch set 1 V -1 09/15/19, 12:15 Completed build in 06s on Sun, 15 Sep, 12:15 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36456

  3. Lina Wolf uploaded patch set 2 09/16/19, 11:45

  4. TYPO3com voted on patch set 2 V -1 09/16/19, 11:45 Completed build in 12s on Mon, 16 Sep, 11:45 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36470

  5. Lina Wolf uploaded patch set 3 09/16/19, 16:53

  6. TYPO3com voted on patch set 3 V -1 09/16/19, 16:53 Completed build in 12s on Mon, 16 Sep, 04:53 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36474

  7. Lina Wolf uploaded patch set 4 09/16/19, 16:54

  8. TYPO3com commented on patch set 4 09/16/19, 16:54 Completed build in 12s on Mon, 16 Sep, 04:54 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36475

  9. Lina Wolf uploaded patch set 5 09/16/19, 17:01

  10. TYPO3com voted on patch set 5 V -1 09/16/19, 17:01 Completed build in 12s on Mon, 16 Sep, 05:01 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36476

  11. Lina Wolf uploaded patch set 6 09/17/19, 08:38

  12. TYPO3com voted on patch set 6 V -1 09/17/19, 08:38 Completed build in 16s on Tue, 17 Sep, 08:38 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36486

  13. Sybille Peters commented on patch set 6 09/17/19, 10:16

    > Patch Set 6: Verified-1 > > Completed build in 16s on Tue, 17 Sep, 08:38 AM > Test Summary: No tests found > Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36486 If you follow this link, you can see why the tests fail: "Error summary for Integration CGL" That is a CGL issue. Run the Build/Script/cglFixMyCommit.sh or the Build/Script/runtTests.sh with the -s cglGit as mentioned.
  14. Sybille Peters rebased onto patch set 7 09/17/19, 11:37

  15. TYPO3com voted on patch set 7 V -1 09/17/19, 11:37 Completed build in 15s on Tue, 17 Sep, 11:37 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36504

  16. Simon Gilli uploaded patch set 8 09/17/19, 12:07

  17. TYPO3com voted on patch set 8 V -1 09/17/19, 12:08 Completed build in 18s on Tue, 17 Sep, 12:08 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36507

  18. Simon Gilli uploaded patch set 9 09/17/19, 12:13

  19. TYPO3com commented on patch set 9 09/17/19, 12:13 Completed build in 12s on Tue, 17 Sep, 12:13 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36508

  20. Sybille Peters uploaded patch set 10 09/17/19, 12:14

  21. TYPO3com voted on patch set 10 V +1 09/17/19, 12:24 Completed build in 09m 48s on Tue, 17 Sep, 12:24 PM Test Summary: 47556 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36509

  22. Dmitry Dulepov updated the commit message in patch set 11 09/17/19, 12:35

  23. TYPO3com voted on patch set 11 V +1 09/17/19, 12:44 Completed build in 09m 47s on Tue, 17 Sep, 12:44 PM Test Summary: 47556 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36510

  24. Sybille Peters voted on patch set 11 V +1 09/23/19, 08:45

  1. Simon Gilli voted on patch set 11 CR +1 09/28/19, 16:15

  2. Daniel Goerz updated the commit message in patch set 12 10/06/19, 20:48

  3. Daniel Goerz commented on patch set 12 10/06/19, 20:49

    I removed the 8.7 backport since this is not a priority bugfix IMO. Patch works, however, broken links in translations of the page are still not included.
  4. TYPO3com voted on patch set 12 V +1 10/06/19, 20:58 Completed build in 10m 17s on Sun, 6 Oct, 08:58 PM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37069

  5. Jörg Bösche voted on patch set 12 V +1 CR +1 10/07/19, 09:03

  6. Sascha Rademacher voted on patch set 12 V +1 CR +1 10/08/19, 12:37

  7. Julian Geils voted on patch set 12 V +1 CR +1 10/08/19, 13:05

  8. Tymoteusz Motylewski uploaded patch set 13 10/22/19, 12:32

  9. TYPO3com voted on patch set 13 V -1 10/22/19, 12:32 Completed build in 11s on Tue, 22 Oct, 12:32 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37446

  10. Tymoteusz Motylewski uploaded patch set 14 10/22/19, 12:35

  11. Tymoteusz Motylewski uploaded patch set 15 10/22/19, 12:37

  12. Tymoteusz Motylewski commented on patch set 15 10/22/19, 12:39

    Fixed issue which prevented from showing errors from pages other than the current page - we now show all pages from the configured levels.
  13. Tymoteusz Motylewski uploaded patch set 16 10/22/19, 12:42

  14. TYPO3com voted on patch set 14 V +1 10/22/19, 12:47 Completed build in 12m 17s on Tue, 22 Oct, 12:47 PM Test Summary: 48014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37447

  15. TYPO3com voted on patch set 15 V +1 10/22/19, 12:49 Completed build in 11m 39s on Tue, 22 Oct, 12:49 PM Test Summary: 48014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37448

  16. TYPO3com voted on patch set 16 V +1 10/22/19, 12:56 Completed build in 12m 05s on Tue, 22 Oct, 12:56 PM Test Summary: 48014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37450

  17. Sybille Peters voted on patch set 16 V +1 CR +1 10/22/19, 13:57

  18. Daniel Goerz uploaded patch set 17 10/22/19, 20:18

  19. TYPO3com voted on patch set 17 V -1 10/22/19, 20:28 Completed build in 10m 26s on Tue, 22 Oct, 08:28 PM Test Summary: 47781 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37470

  20. TYPO3com voted on patch set 17 V +1 10/22/19, 20:54 Completed build in 46m 34s on Tue, 22 Oct, 08:54 PM Test Summary: 48014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37470

  21. Tymoteusz Motylewski voted on patch set 17 V +1 CR +1 10/22/19, 21:42

  22. Sybille Peters voted on patch set 17 V +1 10/23/19, 07:17

  23. Sybille Peters voted on patch set 17 CR +1 10/23/19, 08:35

  24. Daniel Goerz voted on patch set 17 V +2 CR +2 10/23/19, 08:42

  25. Daniel Goerz merged patch set 18 10/23/19, 08:42