Review main Merged

61712[TASK] Add functional tests for linkvalidator

Sybille Peters CR +2 V +2 Hard +489 −0 updated 09/24/19, 06:24

Commit message

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Tymoteusz Motylewski +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Tymoteusz Motylewski +1
    • TYPO3com +1 CI

Issues 1

Files 16

Review log 2033

Show 48 earlier messages
  1. Sybille Peters uploaded patch set 1 09/16/19, 16:11

  2. TYPO3com voted on patch set 1 V -1 09/16/19, 16:20 Completed build in 08m 44s on Mon, 16 Sep, 04:20 PM Test Summary: 47315 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36473

  3. Sybille Peters uploaded patch set 2 09/17/19, 09:34

  4. TYPO3com voted on patch set 2 V -1 09/17/19, 09:39 Completed build in 05m 29s on Tue, 17 Sep, 09:39 AM Test Summary: 40114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36493

  5. Sybille Peters uploaded patch set 3 09/17/19, 09:49

  6. TYPO3com voted on patch set 3 V -1 09/17/19, 09:56 Completed build in 07m 14s on Tue, 17 Sep, 09:56 AM Test Summary: 40112 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36495

  7. Sybille Peters uploaded patch set 4 09/17/19, 10:05

  8. TYPO3com voted on patch set 4 V -1 09/17/19, 10:15 Completed build in 10m 15s on Tue, 17 Sep, 10:15 AM Test Summary: 40114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36498

  1. Andreas Kienast uploaded patch set 5 09/17/19, 11:34

  2. TYPO3com voted on patch set 5 V -1 09/17/19, 11:43 Completed build in 09m 22s on Tue, 17 Sep, 11:43 AM Test Summary: 47595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36503

  3. Sybille Peters uploaded patch set 6 09/17/19, 12:06

  4. TYPO3com voted on patch set 6 V -1 09/17/19, 12:18 Completed build in 11m 32s on Tue, 17 Sep, 12:17 PM Test Summary: 47363 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36506

  5. TYPO3com commented on patch set 6 09/17/19, 12:48 Completed build in 53m 23s on Tue, 17 Sep, 12:48 PM Test Summary: 47595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36506

  6. Andreas Kienast uploaded patch set 7 09/17/19, 12:52

  7. TYPO3com voted on patch set 7 V +1 09/17/19, 13:02 Completed build in 10m 38s on Tue, 17 Sep, 01:02 PM Test Summary: 47595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36512

  8. Guido Schmechel commented on patch set 7 09/18/19, 08:27

    LinkAnalyzerTest.php:24

    ?

    LinkAnalyzerTest.php:88

    I would expect variable in lowerCamelcase here
  9. Sybille Peters uploaded patch set 8 09/18/19, 08:52

  10. Sybille Peters commented on patch set 7 09/18/19, 08:53

    LinkAnalyzerTest.php:24 Reply

    Done

    LinkAnalyzerTest.php:88 Reply

    Done
  11. TYPO3com voted on patch set 8 V -1 09/18/19, 09:02 Completed build in 09m 58s on Wed, 18 Sep, 09:02 AM Test Summary: 47585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36533

  12. Sybille Peters rebased onto patch set 9 09/18/19, 11:36

  13. TYPO3com voted on patch set 9 V -1 09/18/19, 11:50 Completed build in 13m 32s on Wed, 18 Sep, 11:50 AM Test Summary: 1 of 47953 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36542

  14. TYPO3com voted on patch set 9 V +1 09/18/19, 13:22 Completed build in 1h 59m 03s on Wed, 18 Sep, 01:22 PM Test Summary: 47592 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36542

  15. Tymoteusz Motylewski voted on patch set 9 CR +1 09/18/19, 19:30

  16. Lina Wolf uploaded patch set 10 09/18/19, 19:58

  17. Lina Wolf commented on patch set 10 V +1 CR +1 09/18/19, 20:01

    Tests work fine. I added an additional test for page:canonical_link to have a test that doesn't depend on tt_content:bodytext. So it also means, tests are easy to expand to other types of fields.

    LinkAnalyzerTest.php:72

    There is a duplicate key in the array, the test should have a unique name

    LinkAnalyzerTest.php:121

    Comment doesn't say more then array key
  18. TYPO3com voted on patch set 10 V +1 09/18/19, 20:06 Completed build in 07m 56s on Wed, 18 Sep, 08:06 PM Test Summary: 47597 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36565

  19. Sybille Peters uploaded patch set 11 09/23/19, 08:29

  20. Sybille Peters commented on patch set 10 09/23/19, 08:30

    LinkAnalyzerTest.php:72 Reply

    Done

    LinkAnalyzerTest.php:121 Reply

    Done
  21. TYPO3com voted on patch set 11 V +1 09/23/19, 08:50 Completed build in 20m 09s on Mon, 23 Sep, 08:50 AM Test Summary: 47784 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36642

  22. Tymoteusz Motylewski voted on patch set 11 CR +1 09/23/19, 20:41

  23. Tymoteusz Motylewski voted on patch set 11 V +1 09/23/19, 20:41

  24. Anja Leichsenring voted on patch set 11 V +2 CR +2 09/24/19, 06:24

  25. Anja Leichsenring merged patch set 12 09/24/19, 06:24