61712[TASK] Add functional tests for linkvalidator
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Tymoteusz Motylewski +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Tymoteusz Motylewski +1
- TYPO3com +1 CI
Issues 1
Files 16
- typo3/sysext/linkvalidator/Tests/Functional/Fixtures/expected_output_content_with_broken_links_several.csvnew+8 −0
- typo3/sysext/linkvalidator/Tests/Functional/Fixtures/expected_output_content_with_broken_links_several_pages.csvnew+8 −0
- typo3/sysext/linkvalidator/Tests/Functional/Fixtures/expected_output_content_with_broken_link_external.csvnew+3 −0
- typo3/sysext/linkvalidator/Tests/Functional/Fixtures/expected_output_content_with_broken_link_file.csvnew+3 −0
- typo3/sysext/linkvalidator/Tests/Functional/Fixtures/expected_output_content_with_broken_link_none.csvnew+2 −0
- typo3/sysext/linkvalidator/Tests/Functional/Fixtures/expected_output_content_with_broken_link_page.csvnew+3 −0
- typo3/sysext/linkvalidator/Tests/Functional/Fixtures/expected_output_with_broken_link_external_in_canonical_link.csvnew+3 −0
- typo3/sysext/linkvalidator/Tests/Functional/Fixtures/input_content_with_broken_links_several.xmlnew+49 −0
- typo3/sysext/linkvalidator/Tests/Functional/Fixtures/input_content_with_broken_links_several_pages.xmlnew+53 −0
- typo3/sysext/linkvalidator/Tests/Functional/Fixtures/input_content_with_broken_link_external.xmlnew+13 −0
- typo3/sysext/linkvalidator/Tests/Functional/Fixtures/input_content_with_broken_link_file.xmlnew+13 −0
- typo3/sysext/linkvalidator/Tests/Functional/Fixtures/input_content_with_broken_link_page.xmlnew+13 −0
- typo3/sysext/linkvalidator/Tests/Functional/Fixtures/input_page_with_broken_link_external_in_canonical_link.xmlnew+8 −0
- typo3/sysext/linkvalidator/Tests/Functional/LinkAnalyzerTest.php8new+304 −0
- typo3/sysext/linkvalidator/composer.json+5 −0
- composer.json+1 −0
Review log 2033
Show 48 earlier messages
-
Sybille Peters uploaded patch set 1 09/16/19, 16:11
-
TYPO3com voted on patch set 1 V -1 09/16/19, 16:20 Completed build in 08m 44s on Mon, 16 Sep, 04:20 PM Test Summary: 47315 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36473
-
Sybille Peters uploaded patch set 2 09/17/19, 09:34
-
TYPO3com voted on patch set 2 V -1 09/17/19, 09:39 Completed build in 05m 29s on Tue, 17 Sep, 09:39 AM Test Summary: 40114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36493
-
Sybille Peters uploaded patch set 3 09/17/19, 09:49
-
TYPO3com voted on patch set 3 V -1 09/17/19, 09:56 Completed build in 07m 14s on Tue, 17 Sep, 09:56 AM Test Summary: 40112 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36495
-
Sybille Peters uploaded patch set 4 09/17/19, 10:05
-
TYPO3com voted on patch set 4 V -1 09/17/19, 10:15 Completed build in 10m 15s on Tue, 17 Sep, 10:15 AM Test Summary: 40114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36498
-
Andreas Kienast uploaded patch set 5 09/17/19, 11:34
-
TYPO3com voted on patch set 5 V -1 09/17/19, 11:43 Completed build in 09m 22s on Tue, 17 Sep, 11:43 AM Test Summary: 47595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36503
-
Sybille Peters uploaded patch set 6 09/17/19, 12:06
-
TYPO3com voted on patch set 6 V -1 09/17/19, 12:18 Completed build in 11m 32s on Tue, 17 Sep, 12:17 PM Test Summary: 47363 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36506
-
TYPO3com commented on patch set 6 09/17/19, 12:48 Completed build in 53m 23s on Tue, 17 Sep, 12:48 PM Test Summary: 47595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36506
-
Andreas Kienast uploaded patch set 7 09/17/19, 12:52
-
TYPO3com voted on patch set 7 V +1 09/17/19, 13:02 Completed build in 10m 38s on Tue, 17 Sep, 01:02 PM Test Summary: 47595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36512
-
Guido Schmechel commented on patch set 7 09/18/19, 08:27
LinkAnalyzerTest.php:88I would expect variable in lowerCamelcase here -
Sybille Peters uploaded patch set 8 09/18/19, 08:52
-
Sybille Peters commented on patch set 7 09/18/19, 08:53
LinkAnalyzerTest.php:24ReplyDoneLinkAnalyzerTest.php:88ReplyDone -
TYPO3com voted on patch set 8 V -1 09/18/19, 09:02 Completed build in 09m 58s on Wed, 18 Sep, 09:02 AM Test Summary: 47585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36533
-
Sybille Peters rebased onto patch set 9 09/18/19, 11:36
-
TYPO3com voted on patch set 9 V -1 09/18/19, 11:50 Completed build in 13m 32s on Wed, 18 Sep, 11:50 AM Test Summary: 1 of 47953 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36542
-
TYPO3com voted on patch set 9 V +1 09/18/19, 13:22 Completed build in 1h 59m 03s on Wed, 18 Sep, 01:22 PM Test Summary: 47592 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36542
-
Tymoteusz Motylewski voted on patch set 9 CR +1 09/18/19, 19:30
-
Lina Wolf uploaded patch set 10 09/18/19, 19:58
-
Lina Wolf commented on patch set 10 V +1 CR +1 09/18/19, 20:01
Tests work fine. I added an additional test for page:canonical_link to have a test that doesn't depend on tt_content:bodytext. So it also means, tests are easy to expand to other types of fields.LinkAnalyzerTest.php:72There is a duplicate key in the array, the test should have a unique nameLinkAnalyzerTest.php:121Comment doesn't say more then array key -
TYPO3com voted on patch set 10 V +1 09/18/19, 20:06 Completed build in 07m 56s on Wed, 18 Sep, 08:06 PM Test Summary: 47597 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36565
-
Sybille Peters uploaded patch set 11 09/23/19, 08:29
-
Sybille Peters commented on patch set 10 09/23/19, 08:30
LinkAnalyzerTest.php:72ReplyDoneLinkAnalyzerTest.php:121ReplyDone -
TYPO3com voted on patch set 11 V +1 09/23/19, 08:50 Completed build in 20m 09s on Mon, 23 Sep, 08:50 AM Test Summary: 47784 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36642
-
Tymoteusz Motylewski voted on patch set 11 CR +1 09/23/19, 20:41
-
Tymoteusz Motylewski voted on patch set 11 V +1 09/23/19, 20:41
-
Anja Leichsenring voted on patch set 11 V +2 CR +2 09/24/19, 06:24
-
Anja Leichsenring merged patch set 12 09/24/19, 06:24
LinkAnalyzerTest.php:24