Review main Merged

61713[BUGFIX] Render correct preview link in page module

Georg Ringer CR +2 V +2 Easy +11 −2 updated 09/30/19, 12:21

Commit message

If a page is translated and a translation is selected in the columns module of the
page module, the view webpage button must show the translation instead of
the default language.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1113

  1. Georg Ringer uploaded patch set 1 09/17/19, 06:46

  2. Georg Ringer commented on patch set 1 09/17/19, 06:47

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 09/17/19, 06:56 Completed build in 09m 46s on Tue, 17 Sep, 06:56 AM Test Summary: 47556 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36479

  4. Richard Haeser voted on patch set 1 V +1 CR +1 09/17/19, 06:58

  5. Daniel Goerz commented on patch set 1 CR -1 09/17/19, 07:17

    PageLayoutController.php:899

    Looks like two spaces before the "?" Also I'd prefer not to use the "L" parameter. Should work with "&_language" as well.
  6. Benni Mack commented on patch set 1 09/23/19, 12:59

    PageLayoutController.php:899 Reply Unresolved

    if backporting to v9, L parameter is fine, as the PageRouter handles this case then.
  7. Daniel Goerz commented on patch set 2 09/23/19, 13:46

    Published edit on patch set 1.
  8. Daniel Goerz voted on patch set 2 CR +1 09/23/19, 13:47

  9. TYPO3com voted on patch set 2 V +1 09/23/19, 14:06 Completed build in 19m 45s on Mon, 23 Sep, 02:06 PM Test Summary: 47739 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36686

  10. Frank Nägler voted on patch set 2 CR +1 09/25/19, 10:43

  11. Daniel Goerz voted on patch set 2 V +1 09/25/19, 13:55

  12. Frank Nägler voted on patch set 2 V +2 CR +2 09/30/19, 12:21

  13. Frank Nägler merged patch set 3 09/30/19, 12:21