Review main Abandoned

61717[BUGFIX] Use site configuration to get correct host

Thomas Löffler CR 0 V 0 Easy +3 −1 updated 11/20/19, 16:53

Commit message

Workspace preview shows a http:// link being behind
a proxy and the related reverse proxy settings.

UriBuilder should use the domain from site configuration.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 68

  1. Thomas Löffler uploaded patch set 1 09/17/19, 15:07

  2. TYPO3com voted on patch set 1 V -1 09/17/19, 15:08 Completed build in 26s on Tue, 17 Sep, 03:08 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36523

  3. Thomas Löffler uploaded patch set 2 09/17/19, 15:10

  4. Benni Mack commented on patch set 2 09/17/19, 15:12

    UriBuilder.php:142

    if you want to backport this to v9, we should use the SiteMatches (which also considers PseudoSites)
  5. Thomas Löffler commented on patch set 2 09/17/19, 15:20

    UriBuilder.php:142 Reply

    And using `matchByPageId()`?
  6. TYPO3com voted on patch set 2 V -1 09/17/19, 15:23 Completed build in 11m 14s on Tue, 17 Sep, 03:23 PM Test Summary: 7 of 47914 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36524

  7. Benni Mack commented on patch set 2 09/19/19, 19:11

    UriBuilder.php:142 Reply Unresolved

    correct. However, this method is actually used to build a backend URL, not related to the frontend. So staying on the same URL is correct. I guess that the workspace part is building a wrong URL then.
  8. Susi Moog abandoned the change 11/20/19, 16:53

    Abandoned as requested in the ticket.