Review 9.5 Merged

61737[BUGFIX] Handle base paths with mixed FQDN and "/"

Benni Mack CR +2 V +2 Normal +214 −0 updated 09/20/19, 08:28

Commit message

If a site has "/" as its entrypoint but the languages
have FQDNs or subdomains or a mixture between subdomain
the base without domain always gets found and the subdomains
are not considered.

Currently this situation is handled in
  SiteMatcher->getRouteCollectionForAllSites()
which does not fit a certain scheme if there is a mixture.

This change corrects this and adds tests to handle any cases:

- just / as base, and then /de and /en as language base
- just / as base, and then subdmoains or full domains+path as language base
- a full URL as base, and then path parts as language base
- a full URL as base and then full URLs + subdomains as language base
- Also check for http and http variants.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 46

  1. Benni Mack commented on patch set 1 09/20/19, 07:10

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 09/20/19, 07:22 Completed build in 11m 39s on Fri, 20 Sep, 07:22 AM Test Summary: 8 of 51141 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1162

  3. Benni Mack uploaded patch set 2 09/20/19, 08:14

  4. TYPO3com voted on patch set 2 V +1 09/20/19, 08:26 Completed build in 12m 02s on Fri, 20 Sep, 08:26 AM Test Summary: 50673 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1164

  5. Benni Mack voted on patch set 2 V +2 CR +2 09/20/19, 08:28

  6. Benni Mack merged patch set 3 09/20/19, 08:28