Review 9.5 Merged

61743[TASK] Improve PHPDoc of GeneralUtility::_GP

Daniel Goerz CR +2 V +2 Easy +3 −4 updated 09/23/19, 09:21

Commit message

The PHPDoc of GeneralUtility::_GP has been revised.
In detail, the outdated and misleading part about security
has been removed and the return annotation now also
includes NULL as possible return type.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Daniel Goerz commented on patch set 1 09/23/19, 08:47

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/23/19, 09:05 Completed build in 16m 44s on Mon, 23 Sep, 09:05 AM Test Summary: 50685 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1174

  3. Daniel Goerz voted on patch set 1 V +2 CR +2 09/23/19, 09:21

  4. Daniel Goerz merged patch set 2 09/23/19, 09:21