Review TYPO3_8-7 Merged

61745[BUGFIX] Avoid double slash in cache directory

Richard Haeser CR +2 V +2 Easy +9 −17 updated 09/24/19, 11:56

Commit message

When configuring a different cache directory,
the setter is called in SimpleFileBackend, which tries
to add the cache identifier as last directory name.

At this time however the cache identifier is still empty
and the full directory path is composed in setCache anyway.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 57

  1. Richard Haeser commented on patch set 1 09/23/19, 18:03

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/core/Tests/Unit/Cache/Backend/FileBackendTest.php
  2. TYPO3com voted on patch set 1 V -1 09/23/19, 18:03 Completed build in 10s on Mon, 23 Sep, 06:03 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3635

  3. Anja Leichsenring uploaded patch set 2 09/24/19, 11:34

  4. TYPO3com voted on patch set 2 V +1 09/24/19, 11:49 Completed build in 13m 09s on Tue, 24 Sep, 11:49 AM Test Summary: 80400 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3639

  5. Anja Leichsenring voted on patch set 2 V +2 CR +2 09/24/19, 11:52

  6. Richard Haeser commented on patch set 2 09/24/19, 11:55

    This change is ready for review.
  7. Anja Leichsenring merged patch set 3 09/24/19, 11:56