Review 9.5 Merged

61746[TASK] Make "Check TCA in ext_tables.php" install tool wizard more helpful

Richard Haeser CR +2 V +2 Easy +18 −3 updated 09/24/19, 14:26

Commit message

Add information about how user can fix the issue.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1014

  1. Richard Haeser commented on patch set 1 09/23/19, 18:03

    Cherry Picked from branch master. The following files contain Git conflicts: * Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Upgrade/TcaExtTablesCheck.ts * typo3/sysext/install/Resources/Private/Templates/Upgrade/TcaExtTablesCheck.html * typo3/sysext/install/Resources/Public/JavaScript/Module/Upgrade/TcaExtTablesCheck.js
  2. TYPO3com voted on patch set 1 V +1 09/23/19, 18:14 Completed build in 10m 55s on Mon, 23 Sep, 06:14 PM Test Summary: 50685 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1183

  3. Anja Leichsenring uploaded patch set 2 09/24/19, 13:14

  4. Anja Leichsenring updated the commit message in patch set 3 09/24/19, 13:15

  5. Richard Haeser commented on patch set 3 09/24/19, 13:21

    This change is ready for review.
  6. Andreas Kienast commented on patch set 3 09/24/19, 13:39

    Do we really want the minified JS here? I'll update the patch.
  7. Andreas Kienast voted on patch set 3 CR -1 09/24/19, 13:39

  8. Anja Leichsenring commented on patch set 3 09/24/19, 13:41

    > Patch Set 3: > > Do we really want the minified JS here? I'll update the patch. thank you
  9. Andreas Kienast uploaded patch set 4 09/24/19, 13:41

  10. TYPO3com voted on patch set 2 V +1 09/24/19, 13:46 Completed build in 27m 39s on Tue, 24 Sep, 01:46 PM Test Summary: 50730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1192

  11. TYPO3com voted on patch set 3 V +1 09/24/19, 13:55 Completed build in 26m 53s on Tue, 24 Sep, 01:55 PM Test Summary: 50730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1193

  12. TYPO3com voted on patch set 4 V +1 09/24/19, 14:25 Completed build in 34m 48s on Tue, 24 Sep, 02:25 PM Test Summary: 50730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1195

  13. Anja Leichsenring voted on patch set 4 V +2 CR +2 09/24/19, 14:26

  14. Anja Leichsenring merged patch set 5 09/24/19, 14:26