Review 9.5 Merged

61747[TASK] Add functional tests for linkvalidator

Anja Leichsenring CR +2 V +2 Hard +489 −0 updated 09/24/19, 11:27

Commit message

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Sybille Peters +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Sybille Peters +1
    • TYPO3com +1 CI

Issues 1

Files 16

Review log 56

  1. Anja Leichsenring commented on patch set 1 09/24/19, 06:25

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/24/19, 06:55 Completed build in 21m 36s on Tue, 24 Sep, 06:55 AM Test Summary: 50730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1184

  3. Sybille Peters commented on patch set 1 V -1 09/24/19, 07:11

    Running locally in 9.5 branch, I got this error: There was 1 failure: 1) TYPO3\CMS\Linkvalidator\Tests\Unit\Linktype\ExternalLinktypeTest::checkLinkWithExternalUrlNotFoundReturnsFalse tearDown() integrity check found left over singleton instances in GeneralUtilily::makeInstance() instance list. The test should probably set '$this->resetSingletonInstances = true;' to reset this framework state change. Found singletons: TYPO3\CMS\Core\Log\LogManager, TYPO3\CMS\Core\Cache\CacheManager, TYPO3\CMS\Core\Package\PackageManager, TYPO3\CMS\Core\Localization\Locales, TYPO3\CMS\Extbase\SignalSlot\Dispatcher, TYPO3\CMS\Core\Resource\Rendering\RendererRegistry, TYPO3\CMS\Core\Resource\TextExtraction\TextExtractorRegistry, TYPO3\CMS\Core\Resource\Index\ExtractorRegistry, TYPO3\CMS\Core\MetaTag\MetaTagManagerRegistry, TYPO3\CMS\Core\Imaging\IconRegistry, TYPO3\CMS\Extbase\Object\Container\Container, TYPO3\CMS\Core\Category\CategoryRegistry, TYPO3\CMS\Backend\Routing\Router, TYPO3\CMS\Core\Localization\LanguageStore, TYPO3\CMS\Core\Localization\LocalizationFactory, TYPO3\CMS\Extbase\Object\ObjectManager, TYPO3\CMS\Extbase\Reflection\ReflectionService, TYPO3\CMS\Core\LinkHandling\LinkService, TYPO3\CMS\Core\Resource\ResourceFactory, TYPO3\CMS\Core\Resource\Index\FileIndexRepository, TYPO3\CMS\Core\TimeTracker\TimeTracker, TYPO3\CMS\Core\Messaging\FlashMessageService Failed asserting that an array is empty. /var/www/t3coredev9/vendor/typo3/testing-framework/Classes/Core/Unit/UnitTestCase.php:157 I don't know why this error appeared only in 9.5 and not in master, but I can push another patch which sets $this->resetSingletonInstances as explained in https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/Testing/WritingUnit.html#extending-unittestcase
  4. Sybille Peters commented on patch set 1 V +1 CR +1 09/24/19, 07:13

    My bad, the error was for the unit tests.
  5. Anja Leichsenring voted on patch set 1 V +2 CR +2 09/24/19, 11:27

  6. Anja Leichsenring merged patch set 2 09/24/19, 11:27