Review main Merged

61750Revert "[BUGFIX] Generate notification action on rendering"

Andreas Kienast CR +2 V +2 Normal +86 −161 updated 09/24/19, 18:06

Commit message

This reverts commit 78955a67c7da23c839757b4509f11c637e5e88bb.

The approach uses `eval` that is considered insecure.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 11

Review log 79

  1. Andreas Kienast uploaded patch set 1 09/24/19, 10:35

  2. Andreas Kienast updated the commit message in patch set 2 09/24/19, 10:35

  3. Andreas Kienast updated the commit message in patch set 3 09/24/19, 10:41

  4. Frank Nägler voted on patch set 3 V +1 CR +1 09/24/19, 10:43

  5. TYPO3com voted on patch set 3 V -1 09/24/19, 10:51 Completed build in 09m 31s on Tue, 24 Sep, 10:51 AM Test Summary: 8 of 48171 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36739

  6. TYPO3com voted on patch set 3 V +1 09/24/19, 10:53 Completed build in 20m 52s on Tue, 24 Sep, 10:53 AM Test Summary: 47812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36739

  7. Andreas Kienast voted on patch set 3 V +2 CR +2 09/24/19, 10:53

  8. Andreas Kienast merged patch set 4 09/24/19, 10:53

  9. Oliver Hader voted on patch set 4 CR +1 09/24/19, 18:06