Review main Merged

61751Revert "[FEATURE] PHP API for backend JavaScript notifications"

Andreas Kienast CR +2 V +2 Hard +0 −475 updated 09/24/19, 18:06

Commit message

This reverts commit deca7432d45225d1f4c00bd8fd7f05e3d7a0773d.

The PHP API is considered insecure as whole blocks of JavaScript are
manually written into the PageRenderer.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1013

  1. Andreas Kienast uploaded patch set 1 09/24/19, 10:38

  2. Andreas Kienast commented on patch set 1 CR -2 09/24/19, 10:39

  3. TYPO3com voted on patch set 1 V -1 09/24/19, 10:39 Completed build in 22s on Tue, 24 Sep, 10:39 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36738

  4. Andreas Kienast updated the commit message in patch set 2 09/24/19, 10:42

  5. TYPO3com voted on patch set 2 V -1 09/24/19, 10:42 Completed build in 20s on Tue, 24 Sep, 10:42 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36740

  6. Frank Nägler voted on patch set 2 V +1 CR +1 09/24/19, 10:43

  7. Andreas Kienast uploaded patch set 3 09/24/19, 10:55

  8. Andreas Kienast voted on patch set 3 CR 0 09/24/19, 10:55

  9. Frank Nägler voted on patch set 3 V +1 CR +1 09/24/19, 10:57

  10. TYPO3com voted on patch set 3 V +1 09/24/19, 11:07 Completed build in 12m 14s on Tue, 24 Sep, 11:07 AM Test Summary: 47720 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36743

  11. Andreas Kienast voted on patch set 3 V +2 CR +2 09/24/19, 11:08

  12. Andreas Kienast merged patch set 4 09/24/19, 11:08

  13. Oliver Hader voted on patch set 4 CR +1 09/24/19, 18:06