Review main Merged

61754[DOCS] Added missing brackets

TYPO3com CR +2 V +2 Easy +2 −2 updated 09/20/19, 10:11

Commit message

Since includeCssFiles and includeJsFiles are registered as arrays,
the given types in the example should be arrays, too.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Frank Nägler +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 812

  1. TYPO3com uploaded patch set 1 09/18/19, 13:11

  2. TYPO3com voted on patch set 1 V -1 09/18/19, 13:21 Completed build in 09m 58s on Wed, 18 Sep, 01:21 PM Test Summary: 47307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36548

  3. TYPO3com voted on patch set 1 V +1 09/18/19, 13:31 Completed build in 29m 41s on Wed, 18 Sep, 01:31 PM Test Summary: 47555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36548

  4. Oliver Klee voted on patch set 1 CR +1 09/18/19, 19:32

  5. Oliver Klee commented on patch set 1 09/18/19, 19:32

    Unresolved

    Is 9.5 affected as well?
  6. Alexander Lehning commented on patch set 1 09/19/19, 10:35

    > Patch Set 1: > > (1 comment) yes, 9.5 and 8.7 are affected, too
  7. Björn Jacob updated the commit message in patch set 2 09/19/19, 18:33

  8. Björn Jacob commented on patch set 2 09/19/19, 18:36

    According to https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/Appendix/CommitMessage.html#summary-line-first-line we can use [DOCS] as prefix. I've also added 9.5. I don't think this is has to be backported to v8.
  9. TYPO3com voted on patch set 2 V +1 09/19/19, 18:43 Completed build in 10m 11s on Thu, 19 Sep, 06:43 PM Test Summary: 47555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36589

  10. Oli Bartsch voted on patch set 2 CR +1 09/19/19, 21:02

  11. Frank Nägler voted on patch set 2 V +2 CR +2 09/20/19, 10:09

  12. Frank Nägler merged patch set 3 09/20/19, 10:11