Review main Merged

61756[BUGFIX] Adapt flexform container EventListener registration

Henrik Elsner CR +2 V +2 Easy +2 −2 updated 09/23/19, 11:24

Commit message

Enables the functionality to add an inline element inside of
an unsaved inline element

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 913

  1. Henrik Elsner uploaded patch set 1 09/18/19, 15:26

  2. Henrik Elsner updated the commit message in patch set 2 09/18/19, 15:32

  3. TYPO3com voted on patch set 1 V -1 09/18/19, 15:37 Completed build in 10m 38s on Wed, 18 Sep, 03:37 PM Test Summary: 47555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36555

  4. TYPO3com voted on patch set 2 V -1 09/18/19, 15:45 Completed build in 12m 31s on Wed, 18 Sep, 03:45 PM Test Summary: 47555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36557

  5. Benni Mack commented on patch set 2 09/18/19, 16:09

    We need "built" JS files out of it.
  6. Andreas Kienast uploaded patch set 3 09/18/19, 17:35

  7. TYPO3com voted on patch set 3 V +1 09/18/19, 17:45 Completed build in 09m 24s on Wed, 18 Sep, 05:45 PM Test Summary: 47555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36562

  8. Oli Bartsch commented on patch set 3 09/19/19, 06:11

    Could you please add proper linebreaks in the commit message.
  9. Frank Nägler updated the commit message in patch set 4 09/20/19, 09:07

  10. Frank Nägler voted on patch set 4 V +1 CR +1 09/20/19, 09:10

  11. TYPO3com voted on patch set 4 V +1 09/20/19, 09:18 Completed build in 10m 47s on Fri, 20 Sep, 09:18 AM Test Summary: 47739 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36602

  12. Andreas Kienast voted on patch set 4 V +2 CR +2 09/23/19, 11:24

  13. Andreas Kienast merged patch set 5 09/23/19, 11:24