Review main Merged

61762[TASK] Show TCAdefaults configuration in info module

Georg Ringer CR +2 V +2 Easy +4 −0 updated 09/20/19, 07:52

Commit message

The info module must show potential TSconfig values of TCAdefaults.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Josef Glatz +1
    • Björn Jacob +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Josef Glatz +1
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Georg Ringer uploaded patch set 1 09/19/19, 15:12

  2. Georg Ringer commented on patch set 1 09/19/19, 15:12

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 09/19/19, 15:19 Completed build in 07m 37s on Thu, 19 Sep, 03:19 PM Test Summary: 47555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36588

  4. Björn Jacob commented on patch set 1 09/19/19, 16:17

    Unresolved

    Minor nitpick. What is the correct spelling of "TSconfig"? Can we correct "tsconfig" to the correct notation? Thx and sry :/
  5. Benni Mack voted on patch set 1 V +1 CR +1 09/19/19, 18:51

  6. Björn Jacob updated the commit message in patch set 2 09/19/19, 18:55

  7. Björn Jacob commented on patch set 2 V +1 CR +1 09/19/19, 18:55

  8. TYPO3com voted on patch set 2 V +1 09/19/19, 19:03 Completed build in 08m 37s on Thu, 19 Sep, 07:03 PM Test Summary: 47555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36591

  9. Josef Glatz voted on patch set 2 V +1 CR +1 09/20/19, 06:54

  10. Frank Nägler voted on patch set 2 V +2 CR +2 09/20/19, 07:52

  11. Frank Nägler merged patch set 3 09/20/19, 07:52