61764[BUGFIX] Document unsetting array property items in form variants
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Björn Jacob +1
- Mathias Brodala +1
- Benni Mack +1
-
Verified V +2 Done
- Susi Moog +2
- Björn Jacob +1
- Mathias Brodala +1
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1319
-
Christian Eßl uploaded patch set 1 09/20/19, 07:43
-
TYPO3com voted on patch set 1 V -1 09/20/19, 07:51 Completed build in 08m 16s on Fri, 20 Sep, 07:51 AM Test Summary: 1 of 47926 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36595
-
Christian Eßl uploaded patch set 2 09/20/19, 08:04
-
TYPO3com voted on patch set 2 V +1 09/20/19, 08:15 Completed build in 10m 25s on Fri, 20 Sep, 08:15 AM Test Summary: 47567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36597
-
Mathias Brodala commented on patch set 2 V -1 11/21/19, 10:42
With this change a list of items (array) will be overwritten completely which is a) breaking and b) makes it impossible to add values to existing values. So we need a different solution/notation to explicitly support unsetting items by their key. -
Mathias Brodala uploaded patch set 3 11/21/19, 11:06
-
TYPO3com voted on patch set 3 V -1 11/21/19, 11:07 Completed build in 19s on Thu, 21 Nov, 11:07 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38530
-
Mathias Brodala uploaded patch set 4 11/21/19, 11:15
-
TYPO3com voted on patch set 4 V +1 11/21/19, 11:24 Completed build in 08m 33s on Thu, 21 Nov, 11:23 AM Test Summary: 48357 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38533
-
Mathias Brodala uploaded patch set 5 11/21/19, 11:34
-
Mathias Brodala voted on patch set 5 V +1 CR +1 11/21/19, 11:36
-
TYPO3com voted on patch set 5 V +1 11/21/19, 11:41 Completed build in 07m 01s on Thu, 21 Nov, 11:41 AM Test Summary: 48357 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38536
-
Björn Jacob commented on patch set 6 11/21/19, 12:12
Published edit on patch set 5. -
Björn Jacob voted on patch set 6 V +1 CR +1 11/21/19, 12:12
-
Mathias Brodala voted on patch set 6 V +1 CR +1 11/21/19, 12:17
-
TYPO3com voted on patch set 6 V +1 11/21/19, 12:20 Completed build in 07m 59s on Thu, 21 Nov, 12:20 PM Test Summary: 48357 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38539
-
Benni Mack voted on patch set 6 V +1 CR +1 11/21/19, 12:24
-
Susi Moog voted on patch set 6 V +2 CR +2 11/21/19, 12:51
-
Susi Moog merged patch set 7 11/21/19, 12:53