Review main Merged

61766[BUGFIX] Respect fallback languages in slug generation for pages

Christian Eßl CR +2 V +2 Normal +195 −4 updated 01/14/20, 14:09

Commit message

When creating a new subpage of another page, the TCA type "slug" will
automatically generate a slug for the new page which uses the title
of the parent page. When translating the page, the slug will try to get
the correct language for the parent record (if possible). This check did
previously not respect possible fallback languages for the language of
the new record. (configured in the site configuration)

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 3050

Show 1525 earlier messages
  1. Christian Eßl uploaded patch set 1 09/20/19, 09:05

  2. TYPO3com voted on patch set 1 V -1 09/20/19, 09:05 Completed build in 22s on Fri, 20 Sep, 09:05 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36601

  3. Christian Eßl uploaded patch set 2 09/20/19, 09:08

  4. TYPO3com commented on patch set 2 09/20/19, 09:09 Completed build in 21s on Fri, 20 Sep, 09:09 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36603

  5. Christian Eßl uploaded patch set 3 09/20/19, 09:10

  6. TYPO3com voted on patch set 3 V -1 09/20/19, 09:19 Completed build in 09m 31s on Fri, 20 Sep, 09:19 AM Test Summary: 273 of 48021 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36605

  7. Christian Eßl uploaded patch set 4 09/20/19, 09:26

  8. TYPO3com commented on patch set 4 09/20/19, 09:36 Completed build in 09m 34s on Fri, 20 Sep, 09:36 AM Test Summary: 273 of 48021 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36606

  9. Christian Eßl uploaded patch set 5 09/20/19, 09:43

  10. TYPO3com voted on patch set 5 V +1 09/20/19, 09:54 Completed build in 10m 08s on Fri, 20 Sep, 09:54 AM Test Summary: 47739 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36607

  11. Christian Eßl uploaded patch set 6 09/23/19, 15:25

  12. Christian Eßl commented on patch set 6 09/23/19, 15:31

    Fixed a merge conflict after this was merged: https://forge.typo3.org/issues/89225 I'm not sure if I can and should use SiteFinder here as well, because I would like to see this bugfix in 9.5 too.

    SlugHelper.php:28 Unresolved

    Fixed a merge conflict after this was merged: https://forge.typo3.org/issues/89225 I'm not sure if I can and should use SiteFinder here as well, because I would like to see this bugfix in 9.5 to.
  13. TYPO3com voted on patch set 6 V +1 09/23/19, 15:35 Completed build in 09m 37s on Mon, 23 Sep, 03:35 PM Test Summary: 47737 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36696

  14. Oliver Hader commented on patch set 6 CR -1 09/30/19, 15:23

    We should add tests for that case...
  15. Christian Eßl commented on patch set 6 09/30/19, 17:50

    > Patch Set 6: Code-Review-1 > > We should add tests for that case... I will try to write some functional tests later. (As of yet it looks like there arent't any for resolveParentPageRecord...)
  16. Christian Eßl commented on patch set 6 09/30/19, 17:51

    > Patch Set 6: Code-Review-1 > > We should add tests for that case... Thanks. I will try to add some functional tests later. (Looks like there aren't any for resolveParentPageRecord yet)
  17. Christian Eßl uploaded patch set 7 09/30/19, 19:22

  18. TYPO3com voted on patch set 7 V -1 09/30/19, 19:22 Completed build in 11s on Mon, 30 Sep, 07:22 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36967

  19. Christian Eßl uploaded patch set 8 09/30/19, 19:23

  20. TYPO3com voted on patch set 8 V -1 09/30/19, 19:24 Completed build in 15s on Mon, 30 Sep, 07:23 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36968

  21. Christian Eßl uploaded patch set 9 09/30/19, 19:27

  22. TYPO3com voted on patch set 9 V -1 09/30/19, 19:32 Completed build in 04m 58s on Mon, 30 Sep, 07:32 PM Test Summary: 40257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36969

  23. Christian Eßl uploaded patch set 10 09/30/19, 19:35

  24. TYPO3com voted on patch set 10 V -1 09/30/19, 19:42 Completed build in 07m 19s on Mon, 30 Sep, 07:42 PM Test Summary: 40257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36970

  25. Christian Eßl uploaded patch set 11 09/30/19, 19:47

  1. TYPO3com voted on patch set 11 V -1 09/30/19, 19:55 Completed build in 07m 48s on Mon, 30 Sep, 07:55 PM Test Summary: 270 of 48130 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36971

  2. Christian Eßl uploaded patch set 12 09/30/19, 20:15

  3. TYPO3com voted on patch set 12 V -1 09/30/19, 20:15 Completed build in 19s on Mon, 30 Sep, 08:15 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36972

  4. Christian Eßl uploaded patch set 13 09/30/19, 20:21

  5. TYPO3com voted on patch set 13 V -1 09/30/19, 20:31 Completed build in 09m 49s on Mon, 30 Sep, 08:31 PM Test Summary: 270 of 48052 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36973

  6. Christian Eßl uploaded patch set 14 09/30/19, 20:35

  7. TYPO3com voted on patch set 14 V +1 09/30/19, 20:45 Completed build in 09m 51s on Mon, 30 Sep, 08:45 PM Test Summary: 47770 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36974

  8. Markus Klein commented on patch set 14 10/14/19, 11:26

    SlugHelper.php:607 Unresolved

    this is IMO not needed. we can simply array_merge with an empty array too
  9. Christian Eßl rebased onto patch set 15 10/14/19, 15:24

  10. Christian Eßl uploaded patch set 16 10/14/19, 15:26

  11. TYPO3com voted on patch set 15 V -1 10/14/19, 15:37 Completed build in 12m 42s on Mon, 14 Oct, 03:37 PM Test Summary: 1 of 48353 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37316

  12. TYPO3com voted on patch set 16 V +1 10/14/19, 15:41 Completed build in 14m 32s on Mon, 14 Oct, 03:41 PM Test Summary: 47994 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37317

  13. Markus Klein voted on patch set 16 CR +1 10/14/19, 18:57

  14. Markus Klein commented on patch set 17 01/13/20, 13:14

    Published edit on patch set 16.
  15. TYPO3com voted on patch set 17 V -1 01/13/20, 13:14 Completed build in 13s on Mon, 13 Jan, 01:14 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39860

  16. Markus Klein uploaded patch set 18 01/13/20, 14:25

  17. TYPO3com voted on patch set 18 V -1 01/13/20, 14:33 Completed build in 08m 12s on Mon, 13 Jan, 02:33 PM Test Summary: 12 of 69668 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39863

  18. Markus Klein uploaded patch set 19 01/13/20, 14:59

  19. TYPO3com voted on patch set 19 V -1 01/13/20, 15:06 Completed build in 07m 26s on Mon, 13 Jan, 03:06 PM Test Summary: 12 of 69385 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39865

  20. Markus Klein uploaded patch set 20 01/13/20, 19:04

  21. TYPO3com voted on patch set 20 V +1 01/13/20, 19:12 Completed build in 07m 37s on Mon, 13 Jan, 07:12 PM Test Summary: 69218 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39879

  22. Markus Klein voted on patch set 20 V +1 CR +1 01/14/20, 13:25

  23. Benni Mack voted on patch set 20 V +2 CR +2 01/14/20, 14:03

  24. Benni Mack merged patch set 21 01/14/20, 14:03

  25. Sascha Rademacher voted on patch set 20 V +1 CR +1 01/14/20, 14:09