Review main Merged

61770[TASK] Add scroll-padding to .module-body

Harald Atteneder CR +2 V +2 Easy +10 −2 updated 09/24/19, 12:44

Commit message

This fixes the small annoyance when expanding an item in the
TypoScript Object Browser and the iframe reloads and scrolls to the
expanded item while the doc-header hides this item. CSS scroll-padding
solves this problem for modern browsers.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 912

  1. Harald Atteneder uploaded patch set 1 09/21/19, 17:06

  2. TYPO3com voted on patch set 1 V -1 09/21/19, 17:15 Completed build in 08m 50s on Sat, 21 Sep, 05:15 PM Test Summary: 47739 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36619

  3. Harald Atteneder uploaded patch set 2 09/21/19, 17:36

  4. TYPO3com voted on patch set 2 V -1 09/21/19, 17:45 Completed build in 09m 27s on Sat, 21 Sep, 05:45 PM Test Summary: 47201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36620

  5. Andreas Kienast commented on patch set 2 CR -1 09/22/19, 10:16

    Some things I see here: - Shouldn't this be scroll-padding-top? - Releases line should be "master" if it's intended to be in v10 only, since there will be no other v10.0 release - This property is unsupported in Edge - Which node version do you use? The tests fail because the git state of a build is different from the committed one
  6. Harald Atteneder uploaded patch set 3 09/23/19, 07:55

  7. Harald Atteneder commented on patch set 3 09/23/19, 08:01

    > Patch Set 2: Code-Review-1 > > Some things I see here: > > - Shouldn't this be scroll-padding-top? > - Releases line should be "master" if it's intended to be in v10 only, since there will be no other v10.0 release > - This property is unsupported in Edge > - Which node version do you use? The tests fail because the git state of a build is different from the committed one - Changed scroll-padding to scroll-padding-top. Sorry my mistake… - Changed Releases line to master,9.5 - Yes, this property is not supported in Edge. But I would consider it a progressive enhancement, since browsers who do not support this CSS feature simply ignore it. Browsers who support it (https://caniuse.com/#search=scroll-padding-top) get that little bit of extra usability. - Node version is v8.16.0
  8. TYPO3com voted on patch set 3 V +1 09/23/19, 08:06 Completed build in 10m 34s on Mon, 23 Sep, 08:06 AM Test Summary: 47739 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36635

  9. Frank Nägler commented on patch set 3 V +1 CR +1 09/24/19, 11:55

    will not work in IE, but anyway, this a great improvement!
  10. Andreas Kienast voted on patch set 3 V +1 CR +1 09/24/19, 12:30

  11. Frank Nägler voted on patch set 3 V +2 CR +2 09/24/19, 12:44

  12. Frank Nägler merged patch set 4 09/24/19, 12:44