61771[TASK] Keep old value on confirmation modal close
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Frank Nägler +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Frank Nägler +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 2131
Show 36 earlier messages
-
Harald Atteneder uploaded patch set 1 09/21/19, 19:13
-
TYPO3com voted on patch set 1 V +1 09/21/19, 19:23 Completed build in 10m 07s on Sat, 21 Sep, 07:23 PM Test Summary: 47739 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36621
-
Harald Atteneder updated the commit message in patch set 2 09/23/19, 08:03
-
Harald Atteneder updated the commit message in patch set 3 09/23/19, 08:05
-
TYPO3com voted on patch set 2 V +1 09/23/19, 08:15 Completed build in 11m 58s on Mon, 23 Sep, 08:15 AM Test Summary: 47739 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36636
-
TYPO3com voted on patch set 3 V +1 09/23/19, 08:19 Completed build in 13m 59s on Mon, 23 Sep, 08:19 AM Test Summary: 47739 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36637
-
Harald Atteneder uploaded patch set 4 09/23/19, 08:23
-
TYPO3com voted on patch set 4 V -1 09/23/19, 08:34 Completed build in 10m 47s on Mon, 23 Sep, 08:34 AM Test Summary: 47736 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36639
-
TYPO3com voted on patch set 4 V +1 09/23/19, 08:56 Completed build in 11m 51s on Mon, 23 Sep, 08:56 AM Test Summary: 47739 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36644
-
Andreas Kienast commented on patch set 4 09/24/19, 07:37
-
Harald Atteneder uploaded patch set 5 09/24/19, 08:33
-
TYPO3com voted on patch set 5 V +1 09/24/19, 08:48 Completed build in 14m 28s on Tue, 24 Sep, 08:48 AM Test Summary: 47811 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36723
-
Markus Klein commented on patch set 5 09/24/19, 11:15
FormEngine.js:868not sure if it is clever to mix in validation state information into this part of the code. IMO this state has to update automatically, if the field's value is changed -
Harald Atteneder commented on patch set 5 09/24/19, 11:21
FormEngine.js:868ReplyGood point… I will work on fixing this in FormEngineValication.js -
Harald Atteneder uploaded patch set 6 09/24/19, 13:12
-
Harald Atteneder commented on patch set 6 09/24/19, 13:13
FormEngine.js:868ReplyDone -
TYPO3com voted on patch set 6 V +1 09/24/19, 13:32 Completed build in 18m 02s on Tue, 24 Sep, 01:32 PM Test Summary: 47720 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36758
-
Harald Atteneder uploaded patch set 7 09/24/19, 13:35
-
Harald Atteneder uploaded patch set 8 09/24/19, 14:02
-
TYPO3com voted on patch set 7 V +1 09/24/19, 14:12 Completed build in 21m 24s on Tue, 24 Sep, 02:12 PM Test Summary: 47720 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36762
-
TYPO3com voted on patch set 8 V +1 09/24/19, 14:35 Completed build in 12m 25s on Tue, 24 Sep, 02:35 PM Test Summary: 47720 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36765
-
Björn Jacob commented on patch set 8 09/24/19, 17:05
It is better to describe what you've changed with the patch (and not what was broken). So please state, what's now going on. Thx :) -
Harald Atteneder commented on patch set 8 09/24/19, 17:10
Reply Unresolved
> It is better to describe what you've changed with the patch (and not what was broken). So please state, what's now going on. Thx :) Sure. I will update the commit message -
Harald Atteneder updated the commit message in patch set 9 09/24/19, 17:22
-
TYPO3com voted on patch set 9 V +1 09/24/19, 17:32 Completed build in 10m 01s on Tue, 24 Sep, 05:32 PM Test Summary: 47719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36774
-
Frank Nägler voted on patch set 9 V +1 CR +1 09/25/19, 11:20
-
Markus Klein commented on patch set 9 09/25/19, 11:33
FormEngine.js:839Unresolvedin jQuery one should query $field.data('originalValue') see jquery docs for detailsFormEngine.js:840UnresolvedI would say we should move those lines inside the if block below. They are only needed there -
Anja Leichsenring voted on patch set 9 V +2 CR +2 09/25/19, 11:33
-
Anja Leichsenring merged patch set 10 09/25/19, 11:33
-
Oliver Hader wrote 10/07/19, 16:21
Created a revert of this change as I30900d1b80268b263a47ba1c261904f7caa63710
FormEngine.js:844