Review main Merged

61771[TASK] Keep old value on confirmation modal close

Harald Atteneder CR +2 V +2 Easy +32 −12 updated 10/07/19, 16:21

Commit message

When changing the doktype a confirmation modal appears. This patch
reverts the value of the field to the original value after closing the
modal without clicking *OK*.

This works for all selects with 'onChange' => 'reload' and
'renderType' => 'selectSingle'

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 2131

Show 36 earlier messages
  1. Harald Atteneder uploaded patch set 1 09/21/19, 19:13

  2. TYPO3com voted on patch set 1 V +1 09/21/19, 19:23 Completed build in 10m 07s on Sat, 21 Sep, 07:23 PM Test Summary: 47739 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36621

  3. Harald Atteneder updated the commit message in patch set 2 09/23/19, 08:03

  4. Harald Atteneder updated the commit message in patch set 3 09/23/19, 08:05

  5. TYPO3com voted on patch set 2 V +1 09/23/19, 08:15 Completed build in 11m 58s on Mon, 23 Sep, 08:15 AM Test Summary: 47739 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36636

  6. TYPO3com voted on patch set 3 V +1 09/23/19, 08:19 Completed build in 13m 59s on Mon, 23 Sep, 08:19 AM Test Summary: 47739 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36637

  1. Harald Atteneder uploaded patch set 4 09/23/19, 08:23

  2. TYPO3com voted on patch set 4 V -1 09/23/19, 08:34 Completed build in 10m 47s on Mon, 23 Sep, 08:34 AM Test Summary: 47736 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36639

  3. TYPO3com voted on patch set 4 V +1 09/23/19, 08:56 Completed build in 11m 51s on Mon, 23 Sep, 08:56 AM Test Summary: 47739 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36644

  4. Andreas Kienast commented on patch set 4 09/24/19, 07:37

    FormEngine.js:844

    I'd rather initialize the variable with false
  5. Harald Atteneder uploaded patch set 5 09/24/19, 08:33

  6. Harald Atteneder commented on patch set 5 09/24/19, 08:34

    Done

    FormEngine.js:844 Reply

    Done
  7. TYPO3com voted on patch set 5 V +1 09/24/19, 08:48 Completed build in 14m 28s on Tue, 24 Sep, 08:48 AM Test Summary: 47811 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36723

  8. Markus Klein commented on patch set 5 09/24/19, 11:15

    FormEngine.js:868

    not sure if it is clever to mix in validation state information into this part of the code. IMO this state has to update automatically, if the field's value is changed
  9. Harald Atteneder commented on patch set 5 09/24/19, 11:21

    FormEngine.js:868 Reply

    Good point… I will work on fixing this in FormEngineValication.js
  10. Harald Atteneder uploaded patch set 6 09/24/19, 13:12

  11. Harald Atteneder commented on patch set 6 09/24/19, 13:13

    FormEngine.js:868 Reply

    Done
  12. TYPO3com voted on patch set 6 V +1 09/24/19, 13:32 Completed build in 18m 02s on Tue, 24 Sep, 01:32 PM Test Summary: 47720 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36758

  13. Harald Atteneder uploaded patch set 7 09/24/19, 13:35

  14. Harald Atteneder uploaded patch set 8 09/24/19, 14:02

  15. TYPO3com voted on patch set 7 V +1 09/24/19, 14:12 Completed build in 21m 24s on Tue, 24 Sep, 02:12 PM Test Summary: 47720 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36762

  16. TYPO3com voted on patch set 8 V +1 09/24/19, 14:35 Completed build in 12m 25s on Tue, 24 Sep, 02:35 PM Test Summary: 47720 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36765

  17. Björn Jacob commented on patch set 8 09/24/19, 17:05

    It is better to describe what you've changed with the patch (and not what was broken). So please state, what's now going on. Thx :)
  18. Harald Atteneder commented on patch set 8 09/24/19, 17:10

    Reply Unresolved

    > It is better to describe what you've changed with the patch (and not what was broken). So please state, what's now going on. Thx :) Sure. I will update the commit message
  19. Harald Atteneder updated the commit message in patch set 9 09/24/19, 17:22

  20. TYPO3com voted on patch set 9 V +1 09/24/19, 17:32 Completed build in 10m 01s on Tue, 24 Sep, 05:32 PM Test Summary: 47719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36774

  21. Frank Nägler voted on patch set 9 V +1 CR +1 09/25/19, 11:20

  22. Markus Klein commented on patch set 9 09/25/19, 11:33

    FormEngine.js:839 Unresolved

    in jQuery one should query $field.data('originalValue') see jquery docs for details

    FormEngine.js:840 Unresolved

    I would say we should move those lines inside the if block below. They are only needed there
  23. Anja Leichsenring voted on patch set 9 V +2 CR +2 09/25/19, 11:33

  24. Anja Leichsenring merged patch set 10 09/25/19, 11:33

  25. Oliver Hader wrote 10/07/19, 16:21

    Created a revert of this change as I30900d1b80268b263a47ba1c261904f7caa63710