Review main Merged

61773[TASK] Remove obsolet PHPDoc parts

Oli Bartsch CR +2 V +2 Easy +2 −4 updated 09/23/19, 08:51

Commit message

The PHPDocs of GeneralUtility::_GET and GeneralUtility::_POST
have been revised. In detail, statements have been removed
that those methods would strip slashes and should `ALWAYS` be used.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Björn Jacob +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1218

  1. Oli Bartsch uploaded patch set 1 09/22/19, 15:38

  2. Oli Bartsch updated the commit message in patch set 2 09/22/19, 15:39

  3. TYPO3com voted on patch set 1 V -1 09/22/19, 15:49 Completed build in 10m 28s on Sun, 22 Sep, 03:49 PM Test Summary: 47202 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36625

  4. TYPO3com voted on patch set 2 V +1 09/22/19, 15:52 Completed build in 12m 03s on Sun, 22 Sep, 03:52 PM Test Summary: 47739 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36626

  5. Oliver Hader commented on patch set 2 09/22/19, 17:17

    GeneralUtility.php:166

    I think we can remove this line as well... due to magic_quotes it was kind of mandatory in the past, but is not anymore.
  6. Oliver Hader commented on patch set 2 09/22/19, 17:20

    Basically looks good, thx for your patch! :) One next candidate in a separate patch might be method `_GP` in same class - the description seems to be outdated and a bit misleading concerning "security"
  7. Oli Bartsch uploaded patch set 3 09/22/19, 17:43

  8. TYPO3com voted on patch set 3 V -1 09/22/19, 17:53 Completed build in 10m 27s on Sun, 22 Sep, 05:53 PM Test Summary: 47215 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36628

  9. Oli Bartsch commented on patch set 3 09/22/19, 17:54

    > Patch Set 2: > > Basically looks good, thx for your patch! :) > One next candidate in a separate patch might be method `_GP` in same class - the description seems to be outdated and a bit misleading concerning "security" Thank you. I agree with you on the `_GP` method. The description should be improved as you say it looks a litte bit outdated. I'll create a new issue for that.

    GeneralUtility.php:166 Reply

    Done
  10. TYPO3com voted on patch set 3 V +1 09/22/19, 18:06 Completed build in 33m 13s on Sun, 22 Sep, 06:06 PM Test Summary: 47739 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36628

  11. Björn Jacob commented on patch set 3 09/22/19, 18:12

    The commit msg has some problems IMHO. My proposal: "The PHPDocs of GeneralUtility::_GET and GeneralUtility::_POST have been revised. In detail, statements have been removed that those methods would strip slashes and should `ALWAYS` be used."
  12. Oli Bartsch updated the commit message in patch set 4 09/22/19, 18:20

  13. Oli Bartsch commented on patch set 4 09/22/19, 18:21

    Reply Unresolved

    Thank you for your feedback. I totally agree with your proposal and changed it accordingly.
  14. TYPO3com voted on patch set 4 V -1 09/22/19, 18:30 Completed build in 09m 40s on Sun, 22 Sep, 06:30 PM Test Summary: 1 of 47848 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36629

  15. TYPO3com voted on patch set 4 V +1 09/22/19, 19:00 Completed build in 49m 56s on Sun, 22 Sep, 07:00 PM Test Summary: 47739 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36629

  16. Björn Jacob voted on patch set 4 V +1 CR +1 09/23/19, 07:17

  17. Daniel Goerz voted on patch set 4 V +2 CR +2 09/23/19, 08:51

  18. Daniel Goerz merged patch set 5 09/23/19, 08:51