Review main Merged

61774[TASK] Improve PHPDoc of GeneralUtility::_GP

Oli Bartsch CR +2 V +2 Easy +3 −4 updated 09/23/19, 08:47

Commit message

The PHPDoc of GeneralUtility::_GP has been revised.
In detail, the outdated and misleading part about security
has been removed and the return annotation now also
includes NULL as possible return type.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Björn Jacob +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 57

  1. Oli Bartsch uploaded patch set 1 09/22/19, 18:38

  2. Oli Bartsch updated the commit message in patch set 2 09/22/19, 18:44

  3. TYPO3com voted on patch set 1 V +1 09/22/19, 18:48 Completed build in 09m 41s on Sun, 22 Sep, 06:48 PM Test Summary: 47739 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36630

  4. TYPO3com voted on patch set 2 V +1 09/22/19, 18:54 Completed build in 10m 06s on Sun, 22 Sep, 06:54 PM Test Summary: 47739 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36631

  5. Björn Jacob voted on patch set 2 V +1 CR +1 09/23/19, 07:19

  6. Daniel Goerz voted on patch set 2 V +2 CR +2 09/23/19, 08:47

  7. Daniel Goerz merged patch set 3 09/23/19, 08:47