Review main Merged

61780[BUGFIX] Do not assign variables to removed property

Benni Mack CR +2 V +2 Easy +0 −2 updated 09/23/19, 12:30

Commit message

The new IPlocker (supporting IPv6) also removed the public property
AbstractUserAuthentication->lockIP.

However, the original assignments are still in place, as they were forgotten
before the 10.0 release.

The change removes the two assignments.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Markus Klein +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 78

  1. Benni Mack uploaded patch set 1 09/23/19, 11:57

  2. Benni Mack updated the commit message in patch set 2 09/23/19, 11:58

  3. Markus Klein updated the commit message in patch set 3 09/23/19, 11:58

  4. Andreas Kienast voted on patch set 3 V +1 CR +1 09/23/19, 11:59

  5. Markus Klein voted on patch set 3 V +1 CR +1 09/23/19, 12:01

  6. Andreas Kienast voted on patch set 3 V +2 CR +2 09/23/19, 12:27

  7. TYPO3com voted on patch set 3 V +1 09/23/19, 12:30 Completed build in 23m 53s on Mon, 23 Sep, 12:30 PM Test Summary: 47739 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36670

  8. Andreas Kienast merged patch set 4 09/23/19, 12:30