Review TYPO3_8-7 Merged

61783[TASK] Update Fluid engine to 2.6.4

Anja Leichsenring CR +2 V +2 Easy +13 −14 updated 10/16/19, 07:44

Commit message

Addresses the following issues:

* Fixes an annotation that makes phpdocumentor/reflection-docblock
  throw exceptions in TYPO3v10.
* Removes deprecation warning from composer due
  to incorrectly cased package name.
* Fixes issues with binary characters in compiled templates.
* Supports overloaded methods for variable extraction.
* Avoids signature issues with CompileWithRenderStatic.
* Works around PCRE regression issues on affected platforms.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 45

  1. Anja Leichsenring uploaded patch set 1 09/23/19, 14:07

  2. TYPO3com voted on patch set 1 V +1 09/23/19, 14:35 Completed build in 22m 18s on Mon, 23 Sep, 02:35 PM Test Summary: 80400 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3633

  3. Anja Leichsenring voted on patch set 1 V +2 CR +2 09/23/19, 14:35

  4. Anja Leichsenring merged patch set 2 09/23/19, 14:35

  5. Andreas Kienast commented on patch set 2 10/16/19, 07:44

    -1: this causes a regression, see https://forge.typo3.org/issues/89427