Review main Merged

61784[TASK] Use ESLint as base for linting

Andreas Kienast CR +2 V +2 Expert +957 −676 updated 09/25/19, 07:50

Commit message

TSLint is in a deprecation phase, recommending to migrate to ESLint
instead. This patch removes all TSLint packages and supplies a proper
ESLint configuration.

Also, rule violations are fixed in this patch.

Executed commands:

  yarn add --dev typescript-eslint \
    @typescript-eslint/parser \
    @typescript-eslint/eslint-plugin \
    eslint grunt-eslint

  yarn remove tslint grunt-tslint

  ./node_modules/.bin/eslint -c eslintrc.js --fix --ext .ts \
    ./Sources/TypeScript/

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 66

Show 46 more files

Review log 1321

  1. Andreas Kienast uploaded patch set 1 09/23/19, 14:21

  2. TYPO3com voted on patch set 1 V -1 09/23/19, 14:26 Completed build in 27s on Mon, 23 Sep, 02:26 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36692

  3. Andreas Kienast uploaded patch set 2 09/23/19, 15:42

  4. TYPO3com voted on patch set 2 V -1 09/23/19, 15:51 Completed build in 08m 38s on Mon, 23 Sep, 03:51 PM Test Summary: 47737 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36697

  5. Andreas Kienast updated the commit message in patch set 3 09/23/19, 16:55

  6. TYPO3com voted on patch set 3 V -1 09/23/19, 17:12 Completed build in 16m 19s on Mon, 23 Sep, 05:12 PM Test Summary: 47737 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36702

  7. Andreas Kienast uploaded patch set 4 09/24/19, 07:27

  8. TYPO3com voted on patch set 4 V -1 09/24/19, 07:27 Completed build in 09s on Tue, 24 Sep, 07:27 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36716

  9. Andreas Kienast uploaded patch set 5 09/24/19, 07:31

  10. TYPO3com voted on patch set 5 V +1 09/24/19, 07:46 Completed build in 14m 40s on Tue, 24 Sep, 07:46 AM Test Summary: 47782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36718

  11. Andreas Kienast uploaded patch set 6 09/24/19, 12:44

  12. TYPO3com voted on patch set 6 V +1 09/24/19, 12:56 Completed build in 11m 53s on Tue, 24 Sep, 12:56 PM Test Summary: 47720 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36754

  13. Anja Leichsenring voted on patch set 6 V +1 CR +1 09/24/19, 15:44

  14. Andreas Kienast uploaded patch set 7 09/25/19, 07:06

  15. TYPO3com voted on patch set 7 V -1 09/25/19, 07:15 Completed build in 09m 31s on Wed, 25 Sep, 07:15 AM Test Summary: 1 of 48079 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36782

  16. TYPO3com voted on patch set 7 V +1 09/25/19, 07:17 Completed build in 20m 18s on Wed, 25 Sep, 07:17 AM Test Summary: 47720 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36782

  17. Anja Leichsenring voted on patch set 7 V +1 CR +1 09/25/19, 07:32

  18. Frank Nägler voted on patch set 7 V +2 CR +2 09/25/19, 07:43

  19. Frank Nägler commented on patch set 7 CR -1 09/25/19, 07:44

    oh wait, should we backport this stuff at least for v9? else we will get rebase issues really often
  20. Frank Nägler commented on patch set 7 CR +2 09/25/19, 07:50

    since v10 the files are located in a new place, so backports are still a manual process.
  21. Frank Nägler merged patch set 8 09/25/19, 07:50