Review main Merged

61787[TASK] Remove PhantomJS dependencies

Andreas Kienast CR +2 V +2 Normal +13 −122 updated 09/24/19, 07:17

Commit message

This patch removes extraneous npm packages. They were
required for PhantomJS and are currently unused.

Executed command:

  yarn remove karma-phantomjs-launcher phantomjs-prebuilt

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Benjamin Franzke +1
    • Björn Jacob +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Benjamin Franzke +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 57

  1. Andreas Kienast uploaded patch set 1 09/23/19, 16:57

  2. TYPO3com voted on patch set 1 V +1 09/23/19, 17:17 Completed build in 11m 50s on Mon, 23 Sep, 05:17 PM Test Summary: 47737 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36703

  3. Benjamin Franzke updated the commit message in patch set 2 09/23/19, 18:36

  4. TYPO3com voted on patch set 2 V +1 09/23/19, 18:47 Completed build in 10m 10s on Mon, 23 Sep, 06:47 PM Test Summary: 47737 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36708

  5. Björn Jacob voted on patch set 2 CR +1 09/23/19, 20:00

  6. Anja Leichsenring voted on patch set 2 V +2 CR +2 09/24/19, 07:17

  7. Anja Leichsenring merged patch set 3 09/24/19, 07:17