Review main Merged

61790[TASK] Remove unused property in Extbase DataMapper

Benni Mack CR +2 V +2 Easy +0 −7 updated 09/24/19, 08:34

Commit message

Extbase's DataMapper added a $pageSelectObject (PageRepository) as property
in 2009 but it was never used due to further abstractions into the DbBackend
of Extbase.

The protected property is unneeded and can safely be removed,
as it is never initialized or used since at least TYPO3 4.5.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Benni Mack uploaded patch set 1 09/24/19, 07:44

  2. TYPO3com voted on patch set 1 V +1 09/24/19, 07:52 Completed build in 08m 15s on Tue, 24 Sep, 07:52 AM Test Summary: 47783 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36720

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 09/24/19, 07:53

  4. Anja Leichsenring voted on patch set 1 V +2 CR +2 09/24/19, 08:34

  5. Anja Leichsenring merged patch set 2 09/24/19, 08:34