Review main Merged

61791[TASK] Remove unused signal/slot in EM site setup

Benni Mack CR +2 V +2 Easy +0 −20 updated 09/24/19, 09:45

Commit message

A new signal was added with https://review.typo3.org/c/Packages/TYPO3.CMS/+/61554
which has no effect and with the provided information
is not needed. If necessary, a new PSR-14 event should
 be invoked at that place.

The patch removes the signal again.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 46

  1. Benni Mack uploaded patch set 1 09/24/19, 08:58

  2. Anja Leichsenring voted on patch set 1 V +1 CR +1 09/24/19, 08:58

  3. TYPO3com voted on patch set 1 V -1 09/24/19, 09:07 Completed build in 09m 40s on Tue, 24 Sep, 09:07 AM Test Summary: 47560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36725

  4. TYPO3com voted on patch set 1 V +1 09/24/19, 09:21 Completed build in 32m 35s on Tue, 24 Sep, 09:21 AM Test Summary: 47811 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36725

  5. Frank Nägler voted on patch set 1 V +2 CR +2 09/24/19, 09:44

  6. Frank Nägler merged patch set 2 09/24/19, 09:45