Review main Merged

61794[BUGFIX] Don't make clearable button tabbable

Andreas Kienast CR +2 V +2 Easy +4 −2 updated 09/24/19, 13:36

Commit message

The clearable button now has a `tabindex="-1"` attribute to disallow
focussing it via <TAB>.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Nicole Hummel +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Nicole Hummel +1
    • TYPO3com +1 CI

Issues 2

Files 4

Review log 69

  1. Andreas Kienast uploaded patch set 1 09/24/19, 12:41

  2. TYPO3com voted on patch set 1 V -1 09/24/19, 12:50 Completed build in 09m 06s on Tue, 24 Sep, 12:50 PM Test Summary: 47719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36753

  3. TYPO3com voted on patch set 1 V +1 09/24/19, 12:54 Completed build in 22m 22s on Tue, 24 Sep, 12:54 PM Test Summary: 47720 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36753

  4. Nicole Hummel voted on patch set 1 V +1 CR +1 09/24/19, 12:55

  5. Andreas Kienast updated the commit message in patch set 2 09/24/19, 12:59

  6. Nicole Hummel voted on patch set 2 V +1 CR +1 09/24/19, 13:01

  7. TYPO3com voted on patch set 2 V +1 09/24/19, 13:22 Completed build in 20m 39s on Tue, 24 Sep, 01:22 PM Test Summary: 47720 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36756

  8. Frank Nägler voted on patch set 2 V +2 CR +2 09/24/19, 13:35

  9. Frank Nägler merged patch set 3 09/24/19, 13:36