Review 9.5 Merged

61797[TASK] Add scroll-padding to .module-body

Frank Nägler CR +2 V +2 Easy +10 −2 updated 09/24/19, 13:25

Commit message

This fixes the small annoyance when expanding an item in the
TypoScript Object Browser and the iframe reloads and scrolls to the
expanded item while the doc-header hides this item. CSS scroll-padding
solves this problem for modern browsers.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
  • Verified V +2 Done
    • Frank Nägler +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 68

  1. Frank Nägler uploaded patch set 1 09/24/19, 12:51

  2. Frank Nägler abandoned the change 09/24/19, 12:53

    wrong patchset
  3. Frank Nägler restored the change 09/24/19, 12:54

  4. Frank Nägler uploaded patch set 2 09/24/19, 12:54

  5. TYPO3com voted on patch set 1 V -1 09/24/19, 12:54 Completed build in 35s on Tue, 24 Sep, 12:54 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1190

  6. TYPO3com voted on patch set 2 V +1 09/24/19, 13:20 Completed build in 23m 56s on Tue, 24 Sep, 01:20 PM Test Summary: 50730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1191

  7. Frank Nägler voted on patch set 2 V +2 CR +2 09/24/19, 13:25

  8. Frank Nägler merged patch set 3 09/24/19, 13:25