61805[TASK] Move "Refresh required" modal interception into JavaScript land
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Frank Nägler +1
- Rudy Gnodde +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Frank Nägler +1
- TYPO3com +1 CI
Issues 1
Files 4
Review log 1112
-
Andreas Kienast uploaded patch set 1 09/25/19, 12:28
-
Anja Leichsenring voted on patch set 1 V +1 CR +1 09/25/19, 12:40
-
TYPO3com voted on patch set 1 V +1 09/25/19, 12:42 Completed build in 13m 31s on Wed, 25 Sep, 12:42 PM Test Summary: 50730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1208
-
Rudy Gnodde voted on patch set 1 CR +1 09/25/19, 13:42
-
Frank Nägler voted on patch set 1 V +1 CR +1 09/25/19, 14:47
-
Anja Leichsenring voted on patch set 1 V +2 CR +2 09/25/19, 14:49
-
Anja Leichsenring merged patch set 2 09/25/19, 14:49
-
Oliver Hader commented on patch set 2 10/07/19, 14:15
-1 Albeit I welcome any change that gets rid of inline and PHP-generated JavaScript, I don't see the necessity to have this back-ported as "[TASK]" to TYPO3 v9. Besides that it introduced a regression: Try changing be_users.admin before and after this change... -
Oliver Hader commented on patch set 2 10/07/19, 16:36
-> regression issue #89363 -
Oliver Hader commented on patch set 2 10/07/19, 17:11
FormEngine.js:1228UnresolvedThat's the problem... this does not work on checkboxes for instance... Compare PHP namespace TYPO3\CMS\Backend\Form\Element and how previous `fieldChangeFunc` was applied for different field types... (onclick, onchange) and on which element - e.g. UserSysFileStorageIsPublicElement seems to be much different to the field that actually holds the value "data[table][uid][field]"... -
Oliver Hader commented on patch set 2 10/14/19, 20:14
-
Andreas Kienast wrote 10/15/19, 06:29
Created a revert of this change as Id180cc8c4c11af7f6d656116507a45f178c1b787