Review 9.5 Merged

61809[TASK] Keep old value on confirmation modal close

Anja Leichsenring CR +2 V +2 Easy +32 −12 updated 10/07/19, 15:19

Commit message

When changing the doktype a confirmation modal appears. This patch
reverts the value of the field to the original value after closing the
modal without clicking *OK*.

This works for all selects with 'onChange' => 'reload' and
'renderType' => 'selectSingle'

Review

  • Code review CR +2 Done
    • Tobi Kretschmann +2
    • Sascha Rademacher +1
  • Verified V +2 Done
    • Tobi Kretschmann +2
    • Sascha Rademacher +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1214

  1. Anja Leichsenring uploaded patch set 1 09/25/19, 14:52

  2. Anja Leichsenring updated the commit message in patch set 2 09/25/19, 14:53

  3. TYPO3com voted on patch set 1 V +1 09/25/19, 15:10 Completed build in 17m 30s on Wed, 25 Sep, 03:10 PM Test Summary: 50730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1210

  4. TYPO3com voted on patch set 2 V +1 09/25/19, 15:20 Completed build in 21m 43s on Wed, 25 Sep, 03:20 PM Test Summary: 50730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1211

  5. Sascha Rademacher voted on patch set 2 V +1 CR +1 10/07/19, 12:16

  6. Tobi Kretschmann voted on patch set 2 V +2 CR +2 10/07/19, 13:17

  7. Tobi Kretschmann merged patch set 3 10/07/19, 13:17

  8. Oliver Hader commented on patch set 3 10/07/19, 13:42

    -1 UX-wise on a single(!) record I would agree - but there are situations where this change has an impact
  9. Oliver Hader commented on patch set 3 10/07/19, 13:44

    > Patch Set 3: > > -1 UX-wise on a single(!) record I would agree - but there are situations where this change has an impact Imagine nested records (IRRE) where changing the type would require to reload the whole view. A simple use-case can be tested with ext:news and using e.g. 10 inline elements. Try to change all 10 from "text" to "text with media"...
  10. Oliver Hader commented on patch set 3 10/07/19, 13:46

    -1 I don't see this in 9.5, in case somebody does, please explain why - the subject says "[TASK]". From my point of view this change has implications and changes UX behavior in TYPO3 v9 LTS
  11. Tobi Kretschmann commented on patch set 3 10/07/19, 14:03

    > Patch Set 3: > > > Patch Set 3: > > > > -1 UX-wise on a single(!) record I would agree - but there are situations where this change has an impact > > Imagine nested records (IRRE) where changing the type would require to reload the whole view. A simple use-case can be tested with ext:news and using e.g. 10 inline elements. Try to change all 10 from "text" to "text with media"... I see your point and I honestly didn't think of this use case. To address this differently we could add another button to the modal saying something like "Keep the change/reload later". This of course only for the master and revert the 9.5 branch to previous state. What do you think?
  12. Oliver Hader commented on patch set 3 10/07/19, 14:09

    > Patch Set 3: > > > Patch Set 3: > > > > > Patch Set 3: > > > > > > -1 UX-wise on a single(!) record I would agree - but there are situations where this change has an impact > > > > Imagine nested records (IRRE) where changing the type would require to reload the whole view. A simple use-case can be tested with ext:news and using e.g. 10 inline elements. Try to change all 10 from "text" to "text with media"... > > I see your point and I honestly didn't think of this use case. > > To address this differently we could add another button to the modal saying something like "Keep the change/reload later". This of course only for the master and revert the 9.5 branch to previous state. > > What do you think? Another ticket referenced to the report for this very change on forge described the problem already: https://forge.typo3.org/issues/34624 (created 7 years ago) Adding more buttons doesn't make the whole thing better. I'd opt for reverting both changes in master and v9.5, then think about a concept how this can be solved in general (avoid reloading, reload in background, whatever) and then implement an according solution. Besides that, e.g. be_users.admin is of type checkbox and does not seem to be considered by this change. We should aim for having consistent behavior and not just fixing "our use-case"... (this statement is meant in general, not in particular)
  13. Frank Nägler commented on patch set 3 10/07/19, 14:22

    > Adding more buttons doesn't make the whole thing better. I'd opt for reverting both changes in master and v9.5, then think about a concept how this can be solved in general (avoid reloading, reload in background, whatever) and then implement an according solution. Agree, more buttons is not a good idea, I am also fine with a revert. The use case you described with EXT:news is new to me but looks valid. > Besides that, e.g. be_users.admin is of type checkbox and does not seem to be considered by this change... be_users.admin checkbox is not related, the field has no confirm modal yet (or before this patch), correct me if I am wrong, but I reverted the patch locally and changing the toggle will not trigger a modal.
  14. Tobi Kretschmann wrote 10/07/19, 15:19

    Created a revert of this change as I5632db8f5852900b37db473709ddeee4c1ad1d36