Review main Abandoned

61810[BUGFIX] Merge nested array before iteration

Andreas Kienast CR 0 V 0 Easy +2 −2 updated 09/25/19, 16:45

Commit message

`$localeDependencies` is now merged into a flat array before iteration
to fix using wrong offset types.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 1

Review log 79

  1. Andreas Kienast uploaded patch set 1 09/25/19, 14:52

  2. Anja Leichsenring voted on patch set 1 V +1 CR +1 09/25/19, 14:56

  3. Anja Leichsenring uploaded patch set 2 09/25/19, 15:00

  4. Anja Leichsenring voted on patch set 2 V +1 CR +1 09/25/19, 15:01

  5. TYPO3com voted on patch set 1 V +1 09/25/19, 15:13 Completed build in 20m 19s on Wed, 25 Sep, 03:13 PM Test Summary: 47748 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36817

  6. TYPO3com voted on patch set 2 V +1 09/25/19, 15:23 Completed build in 17m 49s on Wed, 25 Sep, 03:23 PM Test Summary: 47748 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36818

  7. Oliver Hader voted on patch set 2 CR -2 09/25/19, 15:35

  8. Oliver Hader commented on patch set 2 09/25/19, 15:35

  9. Andreas Kienast abandoned the change 09/25/19, 16:45