Review main Merged

61820[BUGFIX] Add initialization of DataMapper on QueryResult object wakeup

Tymoteusz Motylewski CR +2 V +2 Easy +1 −0 updated 10/21/19, 17:16

Commit message

`DataMapper` object initialization is missed in this place.
And it leads to error `Call to a member function map() on null` when
`QueryResult` object retrieved from cache.

Review

  • Code review CR +2 Done
    • Tymoteusz Motylewski +2
    • Sascha Rademacher +1
    • Julian Geils +1
    • Jörg Bösche +1
    • Henning Liebe +1
    • Felix P. +1
  • Verified V +2 Done
    • Tymoteusz Motylewski +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1214

  1. Tymoteusz Motylewski commented on patch set 1 09/27/19, 19:50

    Cherry Picked from branch 9.5.
  2. TYPO3com voted on patch set 1 V -1 09/27/19, 20:00 Completed build in 10m 05s on Fri, 27 Sep, 08:00 PM Test Summary: 1 of 48075 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36909

  3. Oliver Klee commented on patch set 1 09/27/19, 22:24

    Unresolved

    Shouldn't this be a [BUGFIX] then?
  4. Tymoteusz Motylewski updated the commit message in patch set 2 10/03/19, 12:26

  5. TYPO3com voted on patch set 2 V +1 10/03/19, 12:37 Completed build in 10m 21s on Thu, 3 Oct, 12:37 PM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37026

  6. Felix P. voted on patch set 2 CR +1 10/07/19, 12:30

  7. Sascha Rademacher voted on patch set 2 CR +1 10/08/19, 07:15

  8. Julian Geils voted on patch set 2 CR +1 10/08/19, 08:09

  9. Jörg Bösche voted on patch set 2 CR +1 10/08/19, 08:45

  10. Henning Liebe voted on patch set 2 CR +1 10/08/19, 08:56

  11. Alexander Schnitzler commented on patch set 2 10/21/19, 17:10

    Hi guys. I'd like to merge this patch but I also need 1 or 2 verfified's from you. If you are confident enough, please vote. I'll take care of the rest then.
  12. Oliver Klee wrote 10/21/19, 17:16

    Removed reviewer Oliver Klee.
  13. Tymoteusz Motylewski voted on patch set 2 V +2 CR +2 10/21/19, 17:16

  14. Alexander Schnitzler merged patch set 3 10/21/19, 17:16