Review 9.5 Merged

61823[BUGFIX] Manage Language Packs: Render empty column if language pack is downloaded

Richard Haeser CR +2 V +2 Easy +14 −12 updated 09/30/19, 14:25

Commit message

If a language pack is available for an extension, the matrix now renders
an empty column to fix wrong positioning of the actual download buttons.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 812

  1. Richard Haeser commented on patch set 1 09/30/19, 12:24

    Cherry Picked from branch master. The following files contain Git conflicts: * Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Maintenance/LanguagePacks.ts * typo3/sysext/install/Resources/Public/JavaScript/Module/Maintenance/LanguagePacks.js
  2. TYPO3com voted on patch set 1 V +1 09/30/19, 12:46 Completed build in 16m 18s on Mon, 30 Sep, 12:46 PM Test Summary: 50730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1226

  3. Frank Nägler uploaded patch set 2 09/30/19, 12:49

  4. TYPO3com voted on patch set 2 V +1 09/30/19, 13:15 Completed build in 15m 49s on Mon, 30 Sep, 01:15 PM Test Summary: 50730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1228

  5. Andreas Kienast voted on patch set 2 V +1 CR +1 09/30/19, 13:47

  6. Richard Haeser commented on patch set 2 09/30/19, 13:49

    This change is ready for review.
  7. Andreas Kienast commented on patch set 2 CR -1 09/30/19, 13:56

    on it
  8. Andreas Kienast uploaded patch set 3 09/30/19, 13:58

  9. Andreas Kienast voted on patch set 3 V +2 CR +2 09/30/19, 13:58

  10. TYPO3com voted on patch set 3 V -1 09/30/19, 14:09 Completed build in 11m 13s on Mon, 30 Sep, 02:09 PM Test Summary: 48987 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1230

  11. TYPO3com voted on patch set 3 V +1 09/30/19, 14:24 Completed build in 36m 58s on Mon, 30 Sep, 02:24 PM Test Summary: 50730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1230

  12. Andreas Kienast merged patch set 4 09/30/19, 14:25