Review main Merged

61837[BUGFIX] Manage Language Packs: Render empty column if language pack is downloaded

Andreas Kienast CR +2 V +2 Easy +14 −12 updated 09/30/19, 12:24

Commit message

If a language pack is available for an extension, the matrix now renders
an empty column to fix wrong positioning of the actual download buttons.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 711

  1. Andreas Kienast uploaded patch set 1 09/26/19, 08:08

  2. Andreas Kienast uploaded patch set 2 09/26/19, 08:10

  3. TYPO3com voted on patch set 1 V +1 09/26/19, 08:18 Completed build in 09m 41s on Thu, 26 Sep, 08:18 AM Test Summary: 47748 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36842

  4. TYPO3com voted on patch set 2 V +1 09/26/19, 08:22 Completed build in 12m 09s on Thu, 26 Sep, 08:22 AM Test Summary: 47748 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36843

  5. Anja Leichsenring updated the commit message in patch set 3 09/26/19, 08:29

  6. TYPO3com voted on patch set 3 V +1 09/26/19, 08:41 Completed build in 11m 51s on Thu, 26 Sep, 08:41 AM Test Summary: 47748 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36844

  7. Andreas Kienast uploaded patch set 4 09/26/19, 09:54

  8. TYPO3com voted on patch set 4 V +1 09/26/19, 10:07 Completed build in 12m 33s on Thu, 26 Sep, 10:07 AM Test Summary: 47748 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36848

  9. Frank Nägler voted on patch set 4 V +1 CR +1 09/30/19, 06:58

  10. Richard Haeser voted on patch set 4 V +2 CR +2 09/30/19, 12:23

  11. Richard Haeser merged patch set 5 09/30/19, 12:24