61838[BUGFIX] Ensure correct site is used when redirecting
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Frank Nägler +1
-
Verified V +2 Done
- Oliver Hader +2
- Frank Nägler +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+9 −2
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+1 −1
- typo3/sysext/redirects/Classes/Service/RedirectService.php+12 −1
- typo3/sysext/redirects/Tests/Functional/Service/IntegrityServiceTest.php+5 −3
- typo3/sysext/redirects/Tests/Unit/Service/RedirectServiceTest.php+8 −1
Review log 1013
-
Andreas Kienast uploaded patch set 1 09/26/19, 09:27
-
TYPO3com voted on patch set 1 V -1 09/26/19, 09:35 Completed build in 07m 44s on Thu, 26 Sep, 09:35 AM Test Summary: 9 of 48041 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36845
-
Andreas Kienast uploaded patch set 2 09/26/19, 09:38
-
TYPO3com voted on patch set 2 V +1 09/26/19, 09:49 Completed build in 10m 50s on Thu, 26 Sep, 09:49 AM Test Summary: 47748 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36846
-
Oliver Hader commented on patch set 2 09/28/19, 12:45
Most actions happens in PageLinkBuilder... besides that fact that TSFE is currently not available (what this patch aims to work around), e.g. `typolinkLinkAccessRestrictedPages` won't be possible anymore for redirects (redirecting to an access restricted page, redirecting again to login page)... Is that on purpose or a side-effect? -
Andreas Kienast commented on patch set 2 09/28/19, 12:47
> Patch Set 2: > > Most actions happens in PageLinkBuilder... besides that fact that TSFE is currently not available (what this patch aims to work around), e.g. `typolinkLinkAccessRestrictedPages` won't be possible anymore for redirects (redirecting to an access restricted page, redirecting again to login page)... Is that on purpose or a side-effect? That's a side-effect if that breaks with the patch. -
Oliver Hader uploaded patch set 3 09/28/19, 13:31
-
Oliver Hader voted on patch set 3 V +1 CR +1 09/28/19, 13:34
-
Frank Nägler voted on patch set 3 CR +1 09/28/19, 13:38
-
TYPO3com voted on patch set 3 V +1 09/28/19, 13:42 Completed build in 11m 05s on Sat, 28 Sep, 01:42 PM Test Summary: 47716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36917
-
Oliver Hader voted on patch set 3 V +2 CR +2 09/28/19, 14:05
-
Oliver Hader merged patch set 4 09/28/19, 14:05
-
Frank Nägler voted on patch set 4 V +1 09/28/19, 14:06