Review main Merged

61838[BUGFIX] Ensure correct site is used when redirecting

Andreas Kienast CR +2 V +2 Easy +35 −8 updated 09/28/19, 14:06

Commit message

The RedirectService recives a NullSite instance from the current
request. This patch checks whether the redirect target is a page and
fetches its site configuration to be able to create a proper TSFE
instance.

Also, the TSFE instance now does not fetch any template configuration
anymore as it is rather extraneous for a redirect.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1013

  1. Andreas Kienast uploaded patch set 1 09/26/19, 09:27

  2. TYPO3com voted on patch set 1 V -1 09/26/19, 09:35 Completed build in 07m 44s on Thu, 26 Sep, 09:35 AM Test Summary: 9 of 48041 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36845

  3. Andreas Kienast uploaded patch set 2 09/26/19, 09:38

  4. TYPO3com voted on patch set 2 V +1 09/26/19, 09:49 Completed build in 10m 50s on Thu, 26 Sep, 09:49 AM Test Summary: 47748 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36846

  5. Oliver Hader commented on patch set 2 09/28/19, 12:45

    Most actions happens in PageLinkBuilder... besides that fact that TSFE is currently not available (what this patch aims to work around), e.g. `typolinkLinkAccessRestrictedPages` won't be possible anymore for redirects (redirecting to an access restricted page, redirecting again to login page)... Is that on purpose or a side-effect?
  6. Andreas Kienast commented on patch set 2 09/28/19, 12:47

    > Patch Set 2: > > Most actions happens in PageLinkBuilder... besides that fact that TSFE is currently not available (what this patch aims to work around), e.g. `typolinkLinkAccessRestrictedPages` won't be possible anymore for redirects (redirecting to an access restricted page, redirecting again to login page)... Is that on purpose or a side-effect? That's a side-effect if that breaks with the patch.
  7. Oliver Hader uploaded patch set 3 09/28/19, 13:31

  8. Oliver Hader voted on patch set 3 V +1 CR +1 09/28/19, 13:34

  9. Frank Nägler voted on patch set 3 CR +1 09/28/19, 13:38

  10. TYPO3com voted on patch set 3 V +1 09/28/19, 13:42 Completed build in 11m 05s on Sat, 28 Sep, 01:42 PM Test Summary: 47716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36917

  11. Oliver Hader voted on patch set 3 V +2 CR +2 09/28/19, 14:05

  12. Oliver Hader merged patch set 4 09/28/19, 14:05

  13. Frank Nägler voted on patch set 4 V +1 09/28/19, 14:06