Review main Merged

6184[BUGFIX] Check for rsaauth being usable

Steffen Gebert CR +2 V +2 Normal +54 −11 updated 06/03/13, 20:49

Commit message

The Extension Manager shows the results of some checks in the
Configuration section of the extension "saltedpasswords", whether
"rsaauth" is loaded and whether it is enabled.

However, it lacks a check for "rsaauth" being really able to work.
If "rsaauth" fails, tell the user that OpenSSL extension is not available
or not working correctly.

Review

  • Code review CR +2
    • Stefan Galinski +2
    • Wouter Wolters +1
    • Helmut Hummel +1
  • Verified V +2
    • Stefan Galinski +2
    • Wouter Wolters +1
    • Helmut Hummel +1

Issues 1

Files 1

Review log 9

  1. Markus Klein commented on patch set 1 10/24/11, 21:42

    (1 inline comment)

    class.tx_saltedpasswords_emconfhelper.php:178

    Please also see my comment there https://review.typo3.org/5689 Even if a backend might be available, the thing is not necessarily working. Also try to get a key pair.
  2. Helmut Hummel commented on patch set 1 10/24/11, 21:42

    (1 inline comment)

    class.tx_saltedpasswords_emconfhelper.php:181

    This will not work unless rsaauth is already installed
  3. Stefan Galinski commented on patch set 2 V 0 10/24/11, 21:42

    by team member; Looks good to me, approved
  4. Helmut Hummel uploaded patch set 2 10/24/11, 21:42

  5. Helmut Hummel commented on patch set 2 10/24/11, 21:42

    Verified; Looks good to me, but someone else must approve Since it is not (easily) possible to check whether rsaauth works correctly without being installed, I moved the check in a place where we can be sure the extension is loaded
  6. Mr. Jenkins commented on patch set 1 10/24/11, 21:42

  7. Mr. Jenkins commented on patch set 2 10/24/11, 21:42

  8. Wouter Wolters commented on patch set 2 10/24/11, 21:42

    Verified; Looks good to me, but someone else must approve
  9. Xavier Perseguers merged patch set 2 10/24/11, 21:42