6184[BUGFIX] Check for rsaauth being usable
Commit message
Review
-
Code review CR +2
- Stefan Galinski +2
- Wouter Wolters +1
- Helmut Hummel +1
-
Verified V +2
- Stefan Galinski +2
- Wouter Wolters +1
- Helmut Hummel +1
Issues 1
Files 1
Review log 9
-
Markus Klein commented on patch set 1 10/24/11, 21:42
(1 inline comment)class.tx_saltedpasswords_emconfhelper.php:178Please also see my comment there https://review.typo3.org/5689 Even if a backend might be available, the thing is not necessarily working. Also try to get a key pair. -
Helmut Hummel commented on patch set 1 10/24/11, 21:42
(1 inline comment)class.tx_saltedpasswords_emconfhelper.php:181This will not work unless rsaauth is already installed -
Stefan Galinski commented on patch set 2 V 0 10/24/11, 21:42
by team member; Looks good to me, approved -
Helmut Hummel uploaded patch set 2 10/24/11, 21:42
-
Helmut Hummel commented on patch set 2 10/24/11, 21:42
Verified; Looks good to me, but someone else must approve Since it is not (easily) possible to check whether rsaauth works correctly without being installed, I moved the check in a place where we can be sure the extension is loaded -
Mr. Jenkins commented on patch set 1 10/24/11, 21:42
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2225/ : SUCCESS -
Mr. Jenkins commented on patch set 2 10/24/11, 21:42
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2235/ : SUCCESS -
Wouter Wolters commented on patch set 2 10/24/11, 21:42
Verified; Looks good to me, but someone else must approve -
Xavier Perseguers merged patch set 2 10/24/11, 21:42