Review main Merged

61841[BUGFIX] Page preview respects language fallbacks

Benni Mack CR +2 V +2 Easy +21 −6 updated 09/28/19, 08:53

Commit message

When a default language page is hidden, it should also be visible
when a translated page is rendered but not available.

The current "simple" check to only check for a specific language
to find out if a page is hidden, is wrong, as l18n_cfg could be built
in a way that a page translation (language>0) does not exist, but
the default record is actually available.

This change overcomes a long-standing issue that
translations of hidden pages can be previewed.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • anonymized-52878 +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Benni Mack uploaded patch set 1 09/26/19, 11:16

  2. TYPO3com voted on patch set 1 V +1 09/26/19, 11:27 Completed build in 10m 28s on Thu, 26 Sep, 11:27 AM Test Summary: 47748 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36851

  3. Benni Mack uploaded patch set 2 09/27/19, 13:56

  4. TYPO3com voted on patch set 2 V +1 09/27/19, 14:15 Completed build in 15m 00s on Fri, 27 Sep, 02:15 PM Test Summary: 47716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36897

  5. anonymized-52878 commented on patch set 2 CR +1 09/27/19, 15:00

    Verified the backport patch for 9.5 branch. This one is basically the same - just a view implementation differences.
  6. Andreas Kienast voted on patch set 2 V +1 CR +1 09/27/19, 16:19

  7. Daniel Goerz voted on patch set 2 V +2 CR +2 09/28/19, 08:53

  8. Daniel Goerz merged patch set 3 09/28/19, 08:53